-
Notifications
You must be signed in to change notification settings - Fork 159
Return Canceled or DeadlineExceeded error code for context errors returned from polling #1230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return Canceled or DeadlineExceeded error code for context errors returned from polling #1230
Conversation
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amacaskill, mattcary The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-1.10 |
@amacaskill: new pull request created: #1231 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-1.9 |
@judemars: #1230 failed to apply on top of branch "release-1.9":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This filters out context errors from the SLO. Right now we are returning Internal error code for
context deadline exceeded
andcontext canceled
errors which are returned fromwaitForZonalOp
orwaitForRegionalOp
. We already did a similar thing in the Filestore CSI Driver here.Here is an example of an error we will now return
DeadlineExceeded
instead ofInternal
:Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: