Skip to content

Eval symlinks for disable device call #1235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 25, 2023
Merged

Eval symlinks for disable device call #1235

merged 1 commit into from
May 25, 2023

Conversation

mattcary
Copy link
Contributor

/kind bug

Fixes #1146

Use correct file path for disable device

/assign @saikat-royc

@mattcary
Eval symlinks for disable device call
ccea136 
Change-Id: I700c53d8620dd924de75921b4dee04963c3fcc4b
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 25, 2023
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 25, 2023
@mattcary mattcary mentioned this pull request May 25, 2023
Closed
@saikat-royc
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 25, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattcary, saikat-royc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [mattcary,saikat-royc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 8d57d5c into master May 25, 2023
@dguendisch dguendisch mentioned this pull request Jun 27, 2023
Closed
@mattcary
Copy link
Contributor Author

/cherry-pick release-1.10
/cherry-pick release-1.9

@k8s-infra-cherrypick-robot
Copy link

@mattcary: new pull request created: #1279

In response to this:

/cherry-pick release-1.10
/cherry-pick release-1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Jun 27, 2023
Merged
@mattcary
Copy link
Contributor Author

/cherry-pick release-1.9

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Jun 27, 2023
Merged
@k8s-infra-cherrypick-robot
Copy link

@mattcary: new pull request created: #1280

In response to this:

/cherry-pick release-1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saikat-royc saikat-royc Awaiting requested review from saikat-royc

@sunnylovestiramisu sunnylovestiramisu Awaiting requested review from sunnylovestiramisu

Assignees

@saikat-royc saikat-royc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DisableDevice not working as expected
4 participants
@mattcary @saikat-royc @k8s-ci-robot @k8s-infra-cherrypick-robot