Eval symlinks for disable device call #1228
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I700c53d8620dd924de75921b4dee04963c3fcc4b
k8s-ci-robot
added
release-note
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mattcary The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
cncf-cla: yes
|
/hold I'll check the logs in the presubmit e2e run to see if this actually fixed it. |
k8s-ci-robot
added
the
do-not-merge/hold
|
No disable device errors found in the cluster logs from the k8s-integration test. |
k8s-ci-robot
removed
the
do-not-merge/hold
saikat-royc
reviewed
May 25, 2023
| if devFsPath, err := filepath.EvalSymlinks(devicePath); err != nil { | ||
| klog.Errorf("filepath.EvalSymlinks(%q) failed when trying to disable device: %w (ignored, unstaging continues)", devicePath, err) | ||
| } else if err := ns.DeviceUtils.DisableDevice(devFsPath); err != nil { | ||
| klog.Errorf("Failed to disabled device %s for volume %s. Device may not be detached cleanly (error is ignored and unstaging is continuing): %w", devicePath, volumeID, err) |
There was a problem hiding this comment.
can we also print the devFsPath
|
For some reason I can't push changes to this PR, so this is moved to #1235 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/kind bug
Fixes #1146
/cc @saikat-royc