Skip to content

Automated cherry pick of #1189: Skip snapshot and restore test because test fix #1191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Automated cherry pick of #1189: Skip snapshot and restore test because test fix #1191

wants to merge 1 commit into from

Conversation

amacaskill
Copy link
Member

@amacaskill amacaskill commented Apr 14, 2023 •
edited
Loading

Cherry pick of #1189 on release-1.8.

#1189: Skip snapshot and restore test because test fix

For details on the cherry pick process, see the cherry pick requests page.

None

@amacaskill
Skip snapshot and restore test because test fix (kubernetes-sigs#972)…
65c0b01 
… is not backported to 1.8-. The fix is only in 1.9+.
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: amacaskill
Once this PR has been reviewed and has the lgtm label, please assign jingxu97 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from jingxu97 April 14, 2023 16:33
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 14, 2023
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. labels Apr 14, 2023
@amacaskill
Copy link
Member Author

/assign @msau42

@msau42
Copy link
Contributor

msau42 commented Apr 14, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 14, 2023
@amacaskill
Copy link
Member Author

/hold The testskip didn't work. #1186

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 14, 2023
@k8s-ci-robot
Copy link
Contributor

@amacaskill: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-gcp-compute-persistent-disk-csi-driver-kubernetes-integration 65c0b01 link true /test pull-gcp-compute-persistent-disk-csi-driver-kubernetes-integration

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@amacaskill
Copy link
Member Author

amacaskill commented Apr 14, 2023 •
edited
Loading

Still not working. These tests create a kubernetes cluster with nodes that have version 1.28, and it's still failing. I don't understand.

I0414 17:05:47.841] NAME                              STATUS                     ROLES    AGE   VERSION
I0414 17:05:47.841] e2e-test-prow-master              Ready,SchedulingDisabled   <none>   53s   v1.28.0-alpha.0.300+4e8c5364bc6ed6
I0414 17:05:47.841] e2e-test-prow-minion-group-5w81   Ready                      <none>   55s   v1.28.0-alpha.0.300+4e8c5364bc6ed6
I0414 17:05:47.841] e2e-test-prow-minion-group-phws   Ready                      <none>   50s   v1.28.0-alpha.0.300+4e8c5364bc6ed6
I0414 17:05:47.841] e2e-test-prow-minion-group-qwg9   Ready                      <none>   7s    v1.28.0-alpha.0.300+4e8c5364bc6ed6

But is that the version that matters?

@msau42
Copy link
Contributor

msau42 commented Apr 14, 2023

The fix itself is in the driver and does not depend on any kubernetes cluster version.

Perhaps for the cherry picks, we should just disable the test case entirely.

@amacaskill
Copy link
Member Author

amacaskill commented Apr 14, 2023 •
edited
Loading

The fix itself is in the driver and does not depend on any kubernetes cluster version.

Perhaps for the cherry picks, we should just disable the test case entirely.

How do I do that? Do you mean just adding a test skip (for all versions) to the release-1.8 and 1.7 branch?

msau42
msau42 reviewed Apr 14, 2023
View reviewed changes
test/k8s-integration/main.go
@@ -598,6 +598,11 @@ func generateGKETestSkip(testParams *testParameters) string {
skipString = skipString + "|pvc.data.source"
}

// Snapshot and restore test fixes were introduced after 1.26 in PR#972.
if curVer.lessThan(mustParseVersion("1.26.0")) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah just remove the version check altogether

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok will fix now.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I am going to just try to do this directly in the cherry picks for the CVE's since this one isn't really necessary

@amacaskill amacaskill closed this Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msau42 msau42 msau42 left review comments

@jingxu97 jingxu97 Awaiting requested review from jingxu97

@saikat-royc saikat-royc Awaiting requested review from saikat-royc

Assignees

@msau42 msau42

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amacaskill @k8s-ci-robot @msau42