Skip to content

Automated cherry pick of #1162: Fix for CVEs #1158: go version updates #1186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

amacaskill
Copy link
Member

@amacaskill amacaskill commented Apr 13, 2023

Cherry pick of #1162 #1158 on release-1.8.

#1162: Fix for CVEs
#1158: go version updates

For details on the cherry pick process, see the cherry pick requests page.

None

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 13, 2023
@k8s-ci-robot k8s-ci-robot requested review from msau42 and saad-ali April 13, 2023 23:47
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 13, 2023
@amacaskill
Copy link
Member Author

/test pull-gcp-compute-persistent-disk-csi-driver-unit

@amacaskill
Copy link
Member Author

/retest

@amacaskill
Copy link
Member Author

amacaskill commented Apr 14, 2023

Test that is failing in last run:

{ failed [FAILED] Filesystem resize failed when restoring from snapshot to PVC with larger size. Restored fs size: 5196382208 bytes is not larger than origin fs size: 5196382208 bytes.
HINT: Your driver needs to check the volume in NodeStageVolume and resize fs if needed.
HINT: For an example patch see: https://github.com/kubernetes/cloud-provider-openstack/pull/1563/files
Expected
    <int>: 5196382208
to be >
    <int>: 5196382208
In [It] at: test/e2e/storage/testsuites/provisioning.go:491 @ 04/14/23 01:53:42.077
}

It failed 2x. So something is wrong.

@amacaskill
Copy link
Member Author

/retest

@amacaskill amacaskill force-pushed the automated-cherry-pick-of-#1162-#1158-upstream-release-1.8 branch from efe027e to f06e16e Compare April 14, 2023 16:42
@amacaskill
Copy link
Member Author

/test pull-gcp-compute-persistent-disk-csi-driver-unit

… is not backported to 1.8-. The fix is only in 1.9+.
@amacaskill amacaskill force-pushed the automated-cherry-pick-of-#1162-#1158-upstream-release-1.8 branch from c2eeaf5 to b887a1f Compare April 14, 2023 19:10
@amacaskill
Copy link
Member Author

/test pull-gcp-compute-persistent-disk-csi-driver-unit

@msau42
Copy link
Contributor

msau42 commented Apr 14, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 14, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amacaskill, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 14, 2023
@k8s-ci-robot k8s-ci-robot merged commit ee1189a into kubernetes-sigs:release-1.8 Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants