Skip to content

release-1.9 cut details for v1.9.0 #1153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 23, 2023
Merged

release-1.9 cut details for v1.9.0 #1153

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ lifecycle of Google Compute Engine Persistent Disks.
## Project Status

Status: GA
Latest stable image: `k8s.gcr.io/cloud-provider-gcp/gcp-compute-persistent-disk-csi-driver:v1.8.2`
Latest stable image: `k8s.gcr.io/cloud-provider-gcp/gcp-compute-persistent-disk-csi-driver:v1.9.0`

### Test Status

Expand Down
12 changes: 6 additions & 6 deletions deploy/kubernetes/images/stable-master/image.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ metadata:
name: imagetag-csi-provisioner
imageTag:
name: k8s.gcr.io/sig-storage/csi-provisioner
newTag: "v3.1.0"
newTag: "v3.4.0"

---
apiVersion: builtin
Expand All @@ -13,7 +13,7 @@ metadata:
name: imagetag-csi-attacher
imageTag:
name: k8s.gcr.io/sig-storage/csi-attacher
newTag: "v3.4.0"
newTag: "v4.2.0"
---

apiVersion: builtin
Expand All @@ -22,7 +22,7 @@ metadata:
name: imagetag-csi-resizer
imageTag:
name: k8s.gcr.io/sig-storage/csi-resizer
newTag: "v1.4.0"
newTag: "v1.7.0"
---

apiVersion: builtin
Expand All @@ -31,7 +31,7 @@ metadata:
name: imagetag-csi-snapshotter
imageTag:
name: k8s.gcr.io/sig-storage/csi-snapshotter
newTag: "v4.0.1"
newTag: "v6.1.0"
---

apiVersion: builtin
Expand All @@ -40,7 +40,7 @@ metadata:
name: imagetag-csi-node-registrar
imageTag:
name: k8s.gcr.io/sig-storage/csi-node-driver-registrar
newTag: "v2.5.0"
newTag: "v2.7.0"
---

apiVersion: builtin
Expand All @@ -52,5 +52,5 @@ imageTag:
# Don't change stable image without changing pdImagePlaceholder in
# test/k8s-integration/main.go
newName: k8s.gcr.io/cloud-provider-gcp/gcp-compute-persistent-disk-csi-driver
newTag: "v1.8.2"
newTag: "v1.9.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to copy all the rc overlay changes here too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the patches from #1144 here.

Copy link
Contributor Author

@sunnylovestiramisu sunnylovestiramisu Feb 23, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://storage.googleapis.com/kubernetes-jenkins/logs/ci-gcp-compute-persistent-disk-csi-driver-release-staging-k8s-master-integration/1628728505032249344/build-log.txt

This is not the log to look at? It says csi-attacher v4.2.0.
With the parameter:

{"name":"csi-attacher","image":"k8s.gcr.io/sig-storage/csi-attacher:v4.2.0","args":["--v=5","--csi-address=/csi/csi.sock","--http-endpoint=:22012","--leader-election","--leader-election-namespace=$(PDCSI_NAMESPACE)","--timeout=250s","--max-grpc-log-length=10000","--default-fstype=ext4"]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added and build bin/kustomize build deploy/kubernetes/overlays/stable-master/

- args:
        - --v=5
        - --csi-address=/csi/csi.sock
        - --http-endpoint=:22012
        - --leader-election
        - --leader-election-namespace=$(PDCSI_NAMESPACE)
        - --timeout=250s
        - --max-grpc-log-length=10000
        - --default-fstype=ext4
        env:
        - name: PDCSI_NAMESPACE
          valueFrom:
            fieldRef:
              fieldPath: metadata.namespace
        image: k8s.gcr.io/sig-storage/csi-attacher:v4.2.0
        livenessProbe:
          failureThreshold: 1
          httpGet:
            path: /healthz/leader-election
            port: http-endpoint
          initialDelaySeconds: 10
          periodSeconds: 20
          timeoutSeconds: 10
        name: csi-attacher
        ports:
        - containerPort: 22012
          name: http-endpoint
          protocol: TCP
        volumeMounts:
        - mountPath: /csi
          name: socket-dir

---
5 changes: 5 additions & 0 deletions deploy/kubernetes/overlays/stable-master/default-fstype.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
# Set default-fstype for attacher sidecar.
- op: add
path: /spec/template/spec/containers/1/args/-
value: "--default-fstype=ext4"

13 changes: 13 additions & 0 deletions deploy/kubernetes/overlays/stable-master/kustomization.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,18 @@ namespace:
gce-pd-csi-driver
resources:
- ../../base/
patchesJson6902:
- path: max-grpc-log-length.yaml
target:
group: apps
kind: Deployment
name: csi-gce-pd-controller
version: v1
- path: default-fstype.yaml
target:
group: apps
kind: Deployment
name: csi-gce-pd-controller
version: v1
transformers:
- ../../images/stable-master
5 changes: 5 additions & 0 deletions deploy/kubernetes/overlays/stable-master/max-grpc-log-length.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
# Set max-grpc-log-length for attacher sidecar.
- op: add
path: /spec/template/spec/containers/1/args/-
value: "--max-grpc-log-length=10000"