-
Notifications
You must be signed in to change notification settings - Fork 159
release-1.9 cut details for v1.9.0 #1153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-1.9 cut details for v1.9.0 #1153
Conversation
Skipping CI for Draft Pull Request. |
/ok-to-test |
/lgtm |
In the test job linked, I don't see the driver deployed with the configuration from https://github.com/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver/blob/master/deploy/kubernetes/images/prow-stable-sidecar-rc-master/image.yaml
|
It looks like the overlay used in the test is |
With the new link, it looks like it's testing the dev overlay, which is based off of stable-master. https://github.com/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver/blob/master/deploy/kubernetes/overlays/dev/kustomization.yaml#L11 |
@@ -52,5 +52,5 @@ imageTag: | |||
# Don't change stable image without changing pdImagePlaceholder in | |||
# test/k8s-integration/main.go | |||
newName: k8s.gcr.io/cloud-provider-gcp/gcp-compute-persistent-disk-csi-driver | |||
newTag: "v1.8.2" | |||
newTag: "v1.9.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you need to copy all the rc overlay changes here too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see the patches from #1144 here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not the log to look at? It says csi-attacher v4.2.0.
With the parameter:
{"name":"csi-attacher","image":"k8s.gcr.io/sig-storage/csi-attacher:v4.2.0","args":["--v=5","--csi-address=/csi/csi.sock","--http-endpoint=:22012","--leader-election","--leader-election-namespace=$(PDCSI_NAMESPACE)","--timeout=250s","--max-grpc-log-length=10000","--default-fstype=ext4"]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added and build bin/kustomize build deploy/kubernetes/overlays/stable-master/
- args:
- --v=5
- --csi-address=/csi/csi.sock
- --http-endpoint=:22012
- --leader-election
- --leader-election-namespace=$(PDCSI_NAMESPACE)
- --timeout=250s
- --max-grpc-log-length=10000
- --default-fstype=ext4
env:
- name: PDCSI_NAMESPACE
valueFrom:
fieldRef:
fieldPath: metadata.namespace
image: k8s.gcr.io/sig-storage/csi-attacher:v4.2.0
livenessProbe:
failureThreshold: 1
httpGet:
path: /healthz/leader-election
port: http-endpoint
initialDelaySeconds: 10
periodSeconds: 20
timeoutSeconds: 10
name: csi-attacher
ports:
- containerPort: 22012
name: http-endpoint
protocol: TCP
volumeMounts:
- mountPath: /csi
name: socket-dir
95b975c
to
e0d62d4
Compare
e0d62d4
to
a4c638a
Compare
a4c638a
to
3315127
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: msau42, sunnylovestiramisu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…k-of-#1153-upstream-release-1.9 Automated cherry pick of #1153: release-1.9 cut details for v1.9.0
/kind feature
What this PR does / why we need it:
Put 1.9.0 release into stable-master. The sidecar update is based on this.
RC passing testgrid since 02-22 20:08 PST (visible google internal only): https://k8s-testgrid.appspot.com/provider-gcp-compute-persistent-disk-csi-driver#Kubernetes%20Master%20Driver%20Latest%20Release%20Candidate
https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/ci-gcp-compute-persistent-disk-csi-driver-release-staging-k8s-master-integration/1628728505032249344 with newest sidecar change.
Refer to #804