Skip to content

release-1.9 cut details for v1.9.0 #1153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 23, 2023

Conversation

sunnylovestiramisu
Copy link
Contributor

@sunnylovestiramisu sunnylovestiramisu commented Feb 22, 2023

/kind feature

What this PR does / why we need it:
Put 1.9.0 release into stable-master. The sidecar update is based on this.

RC passing testgrid since 02-22 20:08 PST (visible google internal only): https://k8s-testgrid.appspot.com/provider-gcp-compute-persistent-disk-csi-driver#Kubernetes%20Master%20Driver%20Latest%20Release%20Candidate

https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/ci-gcp-compute-persistent-disk-csi-driver-release-staging-k8s-master-integration/1628728505032249344 with newest sidecar change.

Refer to #804

None

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 22, 2023
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 22, 2023
@sunnylovestiramisu
Copy link
Contributor Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Feb 22, 2023
@sunnylovestiramisu sunnylovestiramisu marked this pull request as ready for review February 22, 2023 17:58
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 22, 2023
@k8s-ci-robot k8s-ci-robot requested a review from leiyiz February 22, 2023 17:58
@tyuchn
Copy link
Contributor

tyuchn commented Feb 22, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 22, 2023
@msau42
Copy link
Contributor

msau42 commented Feb 22, 2023

In the test job linked, I don't see the driver deployed with the configuration from https://github.com/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver/blob/master/deploy/kubernetes/images/prow-stable-sidecar-rc-master/image.yaml

image: k8s.gcr.io/sig-storage/csi-provisioner:v3.0.0
image: k8s.gcr.io/sig-storage/csi-attacher:v3.2.1
image: k8s.gcr.io/sig-storage/csi-resizer:v1.2.0
image: k8s.gcr.io/sig-storage/csi-snapshotter:v3.0.3
image: gcr.io/k8s-staging-cloud-provider-gcp/gcp-compute-persistent-disk-csi-driver:v1.4.0

@msau42
Copy link
Contributor

msau42 commented Feb 22, 2023

It looks like the overlay used in the test is overlay_name=prow-gke-release-staging-rc-master

@msau42
Copy link
Contributor

msau42 commented Feb 22, 2023

With the new link, it looks like it's testing the dev overlay, which is based off of stable-master. https://github.com/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver/blob/master/deploy/kubernetes/overlays/dev/kustomization.yaml#L11

@@ -52,5 +52,5 @@ imageTag:
# Don't change stable image without changing pdImagePlaceholder in
# test/k8s-integration/main.go
newName: k8s.gcr.io/cloud-provider-gcp/gcp-compute-persistent-disk-csi-driver
newTag: "v1.8.2"
newTag: "v1.9.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to copy all the rc overlay changes here too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the patches from #1144 here.

Copy link
Contributor Author

@sunnylovestiramisu sunnylovestiramisu Feb 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://storage.googleapis.com/kubernetes-jenkins/logs/ci-gcp-compute-persistent-disk-csi-driver-release-staging-k8s-master-integration/1628728505032249344/build-log.txt

This is not the log to look at? It says csi-attacher v4.2.0.
With the parameter:

{"name":"csi-attacher","image":"k8s.gcr.io/sig-storage/csi-attacher:v4.2.0","args":["--v=5","--csi-address=/csi/csi.sock","--http-endpoint=:22012","--leader-election","--leader-election-namespace=$(PDCSI_NAMESPACE)","--timeout=250s","--max-grpc-log-length=10000","--default-fstype=ext4"]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added and build bin/kustomize build deploy/kubernetes/overlays/stable-master/

- args:
        - --v=5
        - --csi-address=/csi/csi.sock
        - --http-endpoint=:22012
        - --leader-election
        - --leader-election-namespace=$(PDCSI_NAMESPACE)
        - --timeout=250s
        - --max-grpc-log-length=10000
        - --default-fstype=ext4
        env:
        - name: PDCSI_NAMESPACE
          valueFrom:
            fieldRef:
              fieldPath: metadata.namespace
        image: k8s.gcr.io/sig-storage/csi-attacher:v4.2.0
        livenessProbe:
          failureThreshold: 1
          httpGet:
            path: /healthz/leader-election
            port: http-endpoint
          initialDelaySeconds: 10
          periodSeconds: 20
          timeoutSeconds: 10
        name: csi-attacher
        ports:
        - containerPort: 22012
          name: http-endpoint
          protocol: TCP
        volumeMounts:
        - mountPath: /csi
          name: socket-dir

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 22, 2023
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 23, 2023
@msau42
Copy link
Contributor

msau42 commented Feb 23, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 23, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msau42, sunnylovestiramisu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 23, 2023
@k8s-ci-robot k8s-ci-robot merged commit 536955b into kubernetes-sigs:master Feb 23, 2023
k8s-ci-robot added a commit that referenced this pull request Feb 23, 2023
…k-of-#1153-upstream-release-1.9

Automated cherry pick of #1153: release-1.9 cut details for v1.9.0
@sunnylovestiramisu sunnylovestiramisu deleted the release-cut branch March 6, 2023 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants