Skip to content

list out regional PD in listDisk Call #1050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 27, 2022

Conversation

leiyiz
Copy link
Contributor

@leiyiz leiyiz commented Sep 23, 2022

What type of PR is this?
/kind bug

What this PR does / why we need it:
Currently regional disks are not being listed out when ListDisk is called. Causing them to all be queued for re-attach, potentially causing quota issues.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:
manually tested and confirmed that the disk is listed out:

/csi.v1.Controller/ListVolumes returned with response: entries:<volume:<volume_id:"projects/leiyi-k8s-testing/regions/us-central1/disks/pvc-416d2e20-136d-4e7b-a332-2df2546d398d" > status:<published_node_ids:"projects/leiyi-k8s-testing/zones/us-central1-c/instances/gke-test-cluster-rapid-default-pool-8dc50175-s6hw" > > ...

Does this PR introduce a user-facing change?:

Fixed issue where Regional disks are repeatedly queued for re-attaching and consuming api quota

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 23, 2022
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Sep 23, 2022
@leiyiz
Copy link
Contributor Author

leiyiz commented Sep 23, 2022

/assign @mattcary

@mattcary
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 23, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leiyiz, mattcary

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 23, 2022
@leiyiz
Copy link
Contributor Author

leiyiz commented Sep 27, 2022

/retest

@k8s-ci-robot k8s-ci-robot merged commit 5d05ed0 into kubernetes-sigs:master Sep 27, 2022
mattcary added a commit that referenced this pull request Nov 23, 2022
…050-upstream-release-1.7

Automated cherry pick of #1050: list out regional PD in listDisk Call
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants