-
Notifications
You must be signed in to change notification settings - Fork 159
[wip] test: update kubetest2 version #1043
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: spiffxp The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Looks like something is more convoluted than I thought:
vs.
Not sure where EDIT: turns out it comes from
Since I'm not sure where the appropriate place to undo that chdir would be, I'll just point kubetest2's |
This brings kubetest2 back up to date, and updates usage to follow the breaking change that caused us to pin to an older version Note that this will prevent test binaries from being uploaded into GCS as part of CI results, but I suspect that wasn't intended to begin with
907aa51
to
fda03cd
Compare
@spiffxp: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Hmm, I suspect we should be able to run customize from the package root (?). Anyway an absolutedir sgtm. |
Hey there! Just letting you know that I have just fixed and re-enabled the sanity tests for PD in go/pdcsi-oss-driver/issues/990 so if you experience failures in your sanity test PR gate build because you're on an old branch before the tests were fixed, merging the latest commits from master into this branch it should make them pass. Let me know if you have any questions! |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close |
@k8s-triage-robot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
WIP because:
This brings kubetest2 back up to date, and updates usage to follow the
breaking change that caused us to pin to an older version
Note that this will prevent test binaries from being uploaded into GCS
as part of CI results, but I suspect that wasn't intended to begin with
Which issue(s) this PR fixes:
Special notes for your reviewer:
This picks up the following kubetest2 changes: kubernetes-sigs/kubetest2@0e09086...26f2492
The breaking change mentioned: kubernetes-sigs/kubetest2#183
Which we pinned to avoid in: #1024
I'll open a PR in the other affected repo if I see CI pass here
Does this PR introduce a user-facing change?: