-
Notifications
You must be signed in to change notification settings - Fork 159
Pin kubetest2 version #1024
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin kubetest2 version #1024
Conversation
Change-Id: I70128504440a9c6b5b14657084206ca50ce2a5e2
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mattcary The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/release-note none |
go install sigs.k8s.io/kubetest2/kubetest2-gce@latest; | ||
go install sigs.k8s.io/kubetest2/kubetest2-gke@latest; | ||
go install sigs.k8s.io/kubetest2/kubetest2-tester-ginkgo@latest; | ||
kt2_version=0e09086b60c122e1084edd2368d3d27fe36f384f |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
consider having a comment about where/how to update this when needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we actually know what the process is to update this is unfortunately?
I think we should also consider that we're doing with release-tools/, as we pull that in but don't actually use it at all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
on filestore side we said something like "ask engprod oncall what version are they using internally if we need to update"
/lgtm |
/kind failing-test
Pin kubetest2 version, as recent changes break the version of ginkgo we're using.
/assign @leiyiz