Skip to content

fixed broken link to implementations #750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 27, 2025

Conversation

nirrozenbaum
Copy link
Contributor

fix #749.

this link got broken when #537 was merged

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 27, 2025
Copy link

netlify bot commented Apr 27, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit fe33dc7
🔍 Latest deploy log https://app.netlify.com/sites/gateway-api-inference-extension/deploys/680e1c350df69600084bf00a
😎 Deploy Preview https://deploy-preview-750--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kfswain
Copy link
Collaborator

kfswain commented Apr 27, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 27, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kfswain, nirrozenbaum

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 27, 2025
@k8s-ci-robot k8s-ci-robot merged commit e845173 into kubernetes-sigs:main Apr 27, 2025
7 checks passed
@nirrozenbaum nirrozenbaum deleted the broken-link branch April 27, 2025 16:48
rlakhtakia pushed a commit to rlakhtakia/gateway-api-inference-extension that referenced this pull request Apr 28, 2025
shmuelk pushed a commit to shmuelk/gateway-api-inference-extension that referenced this pull request Apr 29, 2025
mayabar added a commit to mayabar/gateway-api-inference-extension that referenced this pull request Apr 29, 2025
* dev:
  Read pod role from kubernetes pod info in reconciler (kubernetes-sigs#82)
  feat: Add scripts for kubernetes dev env using vLLM and vLLM-p2p  (kubernetes-sigs#60)
  Add local_config.go which adds custom plugins (kubernetes-sigs#86)
  Fixed merge error
  Removed local version of max score scorer
  Fixed file formatting
  Deleted local version of max scorer
  Add max score picker
  Bump the kubernetes group with 6 updates (kubernetes-sigs#754)
  Add GetEnvString helper function (kubernetes-sigs#758)
  add max score picker (kubernetes-sigs#752)
  Updates from merge
  fixed broken link to implemenations (kubernetes-sigs#750)
  Removed unneeded import
  Added simple tests
  Update expected Results in tests to reflect the updated object
  Add support for Filters and Scorers to have access to all of the request headers and to be able to add request headers
  Weighted scorers (kubernetes-sigs#737)
  fixed broken link to implemenations (kubernetes-sigs#750)

# Conflicts:
#pkg/epp/backend/metrics/pod_metrics.go
#pkg/epp/backend/metrics/types.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implementations reference link in site introduction page is broken
3 participants