add max score picker #752
Merged
add max score picker #752
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updated tests and picker accordingly Signed-off-by: Nir Rozenbaum <[email protected]>
Signed-off-by: Maroon Ayoub <[email protected]>
Signed-off-by: Nir Rozenbaum <[email protected]>
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/L
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kfswain, nirrozenbaum The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
rlakhtakia
pushed a commit
to rlakhtakia/gateway-api-inference-extension
that referenced
this pull request
Apr 30, 2025
* embedded Pod interface into ScoredPod struct. updated tests and picker accordingly Signed-off-by: Nir Rozenbaum <[email protected]> * implemented max-score picker Signed-off-by: Maroon Ayoub <[email protected]> * minor changes in max score picker Signed-off-by: Nir Rozenbaum <[email protected]> --------- Signed-off-by: Nir Rozenbaum <[email protected]> Signed-off-by: Maroon Ayoub <[email protected]> Co-authored-by: Maroon Ayoub <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds max score picker functionality.
if there is more than one pod with the highest score, it choses randomly between those pods.
additionally, the PR embeds Pod interface in the ScoredPod as suggested by @liu-cong in code review of previous PR.