Skip to content

Add library for generating self-signed cert #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 5, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
73 changes: 73 additions & 0 deletions internal/tls/tls.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,73 @@
/*
Copyright 2025 The Kubernetes Authors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/

package tls

import (
"crypto/rand"
"crypto/rsa"
"crypto/tls"
"crypto/x509"
"crypto/x509/pkix"
"encoding/pem"
"fmt"
"math/big"
"time"

"github.com/go-logr/logr"
)

// CreateSelfSignedTLSCertificate creates a self-signed cert the server can use to serve TLS.
func CreateSelfSignedTLSCertificate(logger logr.Logger) (tls.Certificate, error) {
serialNumberLimit := new(big.Int).Lsh(big.NewInt(1), 128)
serialNumber, err := rand.Int(rand.Reader, serialNumberLimit)
if err != nil {
return tls.Certificate{}, fmt.Errorf("error creating serial number: %v", err)
}
now := time.Now()
notBefore := now.UTC()
template := x509.Certificate{
SerialNumber: serialNumber,
Subject: pkix.Name{
Organization: []string{"Inference Ext"},
},
NotBefore: notBefore,
NotAfter: now.Add(time.Hour * 24 * 365 * 10).UTC(), // 10 years
KeyUsage: x509.KeyUsageKeyEncipherment | x509.KeyUsageDigitalSignature,
ExtKeyUsage: []x509.ExtKeyUsage{x509.ExtKeyUsageServerAuth},
BasicConstraintsValid: true,
}

priv, err := rsa.GenerateKey(rand.Reader, 4096)
if err != nil {
return tls.Certificate{}, fmt.Errorf("error generating key: %v", err)
}

derBytes, err := x509.CreateCertificate(rand.Reader, &template, &template, &priv.PublicKey, priv)
if err != nil {
return tls.Certificate{}, fmt.Errorf("error creating certificate: %v", err)
}

certBytes := pem.EncodeToMemory(&pem.Block{Type: "CERTIFICATE", Bytes: derBytes})

privBytes, err := x509.MarshalPKCS8PrivateKey(priv)
if err != nil {
return tls.Certificate{}, fmt.Errorf("error marshalling private key: %v", err)
}
keyBytes := pem.EncodeToMemory(&pem.Block{Type: "PRIVATE KEY", Bytes: privBytes})

return tls.X509KeyPair(certBytes, keyBytes)
}
55 changes: 2 additions & 53 deletions pkg/body-based-routing/server/runserver.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,21 +18,15 @@ package server

import (
"context"
"crypto/rand"
"crypto/rsa"
"crypto/tls"
"crypto/x509"
"crypto/x509/pkix"
"encoding/pem"
"math/big"
"time"

extProcPb "github.com/envoyproxy/go-control-plane/envoy/service/ext_proc/v3"
"github.com/go-logr/logr"
"google.golang.org/grpc"
"google.golang.org/grpc/credentials"
"sigs.k8s.io/controller-runtime/pkg/manager"
"sigs.k8s.io/gateway-api-inference-extension/internal/runnable"
tlsutil "sigs.k8s.io/gateway-api-inference-extension/internal/tls"
"sigs.k8s.io/gateway-api-inference-extension/pkg/body-based-routing/handlers"
)

Expand All @@ -56,7 +50,7 @@ func NewDefaultExtProcServerRunner() *ExtProcServerRunner {
// The runnable implements LeaderElectionRunnable with leader election disabled.
func (r *ExtProcServerRunner) AsRunnable(logger logr.Logger) manager.Runnable {
return runnable.NoLeaderElection(manager.RunnableFunc(func(ctx context.Context) error {
cert, err := createSelfSignedTLSCertificate(logger)
cert, err := tlsutil.CreateSelfSignedTLSCertificate(logger)
if err != nil {
logger.Error(err, "Failed to create self signed certificate")
return err
Expand All @@ -73,48 +67,3 @@ func (r *ExtProcServerRunner) AsRunnable(logger logr.Logger) manager.Runnable {
return runnable.GRPCServer("ext-proc", srv, r.GrpcPort).Start(ctx)
}))
}

func createSelfSignedTLSCertificate(logger logr.Logger) (tls.Certificate, error) {
serialNumberLimit := new(big.Int).Lsh(big.NewInt(1), 128)
serialNumber, err := rand.Int(rand.Reader, serialNumberLimit)
if err != nil {
logger.Error(err, "Failed to create serial number for self-signed cert")
return tls.Certificate{}, err
}
now := time.Now()
notBefore := now.UTC()
template := x509.Certificate{
SerialNumber: serialNumber,
Subject: pkix.Name{
Organization: []string{"Inference Ext"},
},
NotBefore: notBefore,
NotAfter: now.Add(time.Hour * 24 * 365 * 10).UTC(), // 10 years
KeyUsage: x509.KeyUsageKeyEncipherment | x509.KeyUsageDigitalSignature,
ExtKeyUsage: []x509.ExtKeyUsage{x509.ExtKeyUsageServerAuth},
BasicConstraintsValid: true,
}

priv, err := rsa.GenerateKey(rand.Reader, 4096)
if err != nil {
logger.Error(err, "Failed to generate key for self-signed cert")
return tls.Certificate{}, err
}

derBytes, err := x509.CreateCertificate(rand.Reader, &template, &template, &priv.PublicKey, priv)
if err != nil {
logger.Error(err, "Failed to create self-signed certificate")
return tls.Certificate{}, err
}

certBytes := pem.EncodeToMemory(&pem.Block{Type: "CERTIFICATE", Bytes: derBytes})

privBytes, err := x509.MarshalPKCS8PrivateKey(priv)
if err != nil {
logger.Error(err, "Failed to marshal private key for self-signed certificate")
return tls.Certificate{}, err
}
keyBytes := pem.EncodeToMemory(&pem.Block{Type: "PRIVATE KEY", Bytes: privBytes})

return tls.X509KeyPair(certBytes, keyBytes)
}
54 changes: 2 additions & 52 deletions pkg/epp/server/runserver.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,8 @@ package server

import (
"context"
"crypto/rand"
"crypto/rsa"
"crypto/tls"
"crypto/x509"
"crypto/x509/pkix"
"encoding/pem"
"fmt"
"math/big"
"time"

extProcPb "github.com/envoyproxy/go-control-plane/envoy/service/ext_proc/v3"
Expand All @@ -36,6 +30,7 @@ import (
ctrl "sigs.k8s.io/controller-runtime"
"sigs.k8s.io/controller-runtime/pkg/manager"
"sigs.k8s.io/gateway-api-inference-extension/internal/runnable"
tlsutil "sigs.k8s.io/gateway-api-inference-extension/internal/tls"
"sigs.k8s.io/gateway-api-inference-extension/pkg/epp/backend"
"sigs.k8s.io/gateway-api-inference-extension/pkg/epp/controller"
"sigs.k8s.io/gateway-api-inference-extension/pkg/epp/datastore"
Expand Down Expand Up @@ -139,7 +134,7 @@ func (r *ExtProcServerRunner) AsRunnable(logger logr.Logger) manager.Runnable {
cert, err = tls.LoadX509KeyPair(r.CertPath+"/tls.crt", r.CertPath+"/tls.key")
} else {
// Create tls based credential.
cert, err = createSelfSignedTLSCertificate(logger)
cert, err = tlsutil.CreateSelfSignedTLSCertificate(logger)
}
if err != nil {
logger.Error(err, "Failed to create self signed certificate")
Expand All @@ -163,48 +158,3 @@ func (r *ExtProcServerRunner) AsRunnable(logger logr.Logger) manager.Runnable {
return runnable.GRPCServer("ext-proc", srv, r.GrpcPort).Start(ctx)
}))
}

func createSelfSignedTLSCertificate(logger logr.Logger) (tls.Certificate, error) {
serialNumberLimit := new(big.Int).Lsh(big.NewInt(1), 128)
serialNumber, err := rand.Int(rand.Reader, serialNumberLimit)
if err != nil {
logger.Error(err, "Failed to create serial number for self-signed cert")
return tls.Certificate{}, err
}
now := time.Now()
notBefore := now.UTC()
template := x509.Certificate{
SerialNumber: serialNumber,
Subject: pkix.Name{
Organization: []string{"Inference Ext"},
},
NotBefore: notBefore,
NotAfter: now.Add(time.Hour * 24 * 365 * 10).UTC(), // 10 years
KeyUsage: x509.KeyUsageKeyEncipherment | x509.KeyUsageDigitalSignature,
ExtKeyUsage: []x509.ExtKeyUsage{x509.ExtKeyUsageServerAuth},
BasicConstraintsValid: true,
}

priv, err := rsa.GenerateKey(rand.Reader, 4096)
if err != nil {
logger.Error(err, "Failed to generate key for self-signed cert")
return tls.Certificate{}, err
}

derBytes, err := x509.CreateCertificate(rand.Reader, &template, &template, &priv.PublicKey, priv)
if err != nil {
logger.Error(err, "Failed to create self-signed certificate")
return tls.Certificate{}, err
}

certBytes := pem.EncodeToMemory(&pem.Block{Type: "CERTIFICATE", Bytes: derBytes})

privBytes, err := x509.MarshalPKCS8PrivateKey(priv)
if err != nil {
logger.Error(err, "Failed to marshal private key for self-signed certificate")
return tls.Certificate{}, err
}
keyBytes := pem.EncodeToMemory(&pem.Block{Type: "PRIVATE KEY", Bytes: privBytes})

return tls.X509KeyPair(certBytes, keyBytes)
}