This repository was archived by the owner on Dec 6, 2024. It is now read-only.
monorepo: move grpc spec into proto subdir, and update make tools
#80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
k8s-ci-robot
added
do-not-merge/work-in-progress
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
I still have some cleanup to do on this, but the biggest part of making this work is done I think |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BlaineEXE The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
Move the core required files for gRPC specification to ./proto directory. Do not make any file modifications at this point. Signed-off-by: Blaine Gardner <[email protected]>
Fix some package deprecations in proto/hack/fake-gen Signed-off-by: Blaine Gardner <[email protected]>
k8s-ci-robot
removed
do-not-merge/work-in-progress
Modeled after: container-storage-interface/spec#552 Update to the latest, non-deprecated versions of Google's tools for protobuf generation. Also update make tools to allow working with go modules outside of GOPATH, and to build on ARM-based Macbooks. New tools are significantly different from prior tools. Notably, the grpc plugin is no longer supported, so the `--go-gprc_out` flag is used, which moves some generated content from `cosi.pb.go` to a new `cosi_grpc.pb.go` file. We are still able to keep fake-gen by continuing to use deprecated tool versions for that purpose. There's a chance that it may not serve the COSI project long-term, but it should still work for now. Signed-off-by: Blaine Gardner <[email protected]>
|
/lgtm |
k8s-ci-robot
added
the
lgtm
shanduur
pushed a commit
to shanduur/container-object-storage-interface-api
that referenced
this pull request
Aug 2, 2024
…d-in-cloudbuild push images using PROJECT_ID in cloudbuild
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the core required files for gRPC specification to ./proto
directory. Do not make any file modifications at this point.
in a new commit:
Fix some package deprecations in proto/hack/fake-gen
In the final and largest commit:
Modeled after:
container-storage-interface/spec#552
Update to the latest, non-deprecated versions of Google's tools for
protobuf generation.
Also update make tools to allow working with go modules outside of
GOPATH, and to build on ARM-based Macbooks.
New tools are significantly different from prior tools. Notably, the
grpc plugin is no longer supported, so the
--go-gprc_outflag is used,which moves some generated content from
cosi.pb.goto a newcosi_grpc.pb.gofile.We are still able to keep fake-gen by continuing to use deprecated tool
versions for that purpose. There's a chance that it may not serve the
COSI project long-term, but it should still work for now.