Skip to content
This repository was archived by the owner on Dec 6, 2024. It is now read-only.

Commit b33b669

Browse files
committed
proto: update to latest grpc protobuf gen tools
Modeled after: container-storage-interface/spec#552 Update to the latest, non-deprecated versions of Google's tools for protobuf generation. Also update make tools to allow working with go modules outside of GOPATH, and to build on ARM-based Macbooks. New tools are significantly different from prior tools. Notably, the grpc plugin is no longer supported, so the `--go-gprc_out` flag is used, which moves some generated content from `cosi.pb.go` to a new `cosi_grpc.pb.go` file. We are still able to keep fake-gen by continuing to use deprecated tool versions for that purpose. There's a chance that it may not serve the COSI project long-term, but it should still work for now. Signed-off-by: Blaine Gardner <[email protected]>
1 parent eb40da2 commit b33b669

File tree

9 files changed

+895
-827
lines changed

9 files changed

+895
-827
lines changed

Diff for: proto/Makefile

+180-148
Large diffs are not rendered by default.

Diff for: proto/cosi.pb.go

+334-628
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: proto/cosi.pb.json.go

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: proto/cosi.proto

+5-5
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ package cosi.v1alpha1;
44

55
import "google/protobuf/descriptor.proto";
66

7-
option go_package = "sigs.k8s.io/container-object-storage-interface-spec;cosi";
7+
option go_package = "sigs.k8s.io/container-object-storage-interface-api/proto;cosi";
88

99
extend google.protobuf.EnumOptions {
1010
// Indicates that this enum is OPTIONAL and part of an experimental
@@ -166,7 +166,7 @@ message DriverCreateBucketRequest {
166166
}
167167

168168
message DriverCreateBucketResponse {
169-
// bucket_id returned here is expected to be the globally unique
169+
// bucket_id returned here is expected to be the globally unique
170170
// identifier for the bucket in the object storage provider.
171171
string bucket_id = 1;
172172

@@ -178,7 +178,7 @@ message DriverCreateBucketResponse {
178178
message DriverDeleteBucketRequest {
179179
// This field is REQUIRED
180180
// bucket_id is a globally unique identifier for the bucket
181-
// in the object storage provider
181+
// in the object storage provider
182182
string bucket_id = 1;
183183

184184
// This field is OPTIONAL
@@ -194,7 +194,7 @@ message DriverDeleteBucketResponse {
194194
message DriverGrantBucketAccessRequest {
195195
// This field is REQUIRED
196196
// bucket_id is a globally unique identifier for the bucket
197-
// in the object storage provider
197+
// in the object storage provider
198198
string bucket_id = 1;
199199

200200
// This field is REQUIRED
@@ -215,7 +215,7 @@ message DriverGrantBucketAccessRequest {
215215
message DriverGrantBucketAccessResponse {
216216
// This field is REQUIRED
217217
// This is the account_id that is being provided access. This will
218-
// be required later to revoke access.
218+
// be required later to revoke access.
219219
string account_id = 1;
220220

221221
// This field is REQUIRED

Diff for: proto/cosi_grpc.pb.go

+334
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)