-
Notifications
You must be signed in to change notification settings - Fork 29
adds conversion methods between spec and API #23
adds conversion methods between spec and API #23
Conversation
Hi @krishchow. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
cc @wlan0 |
.gitignore
Outdated
@@ -3,3 +3,6 @@ | |||
.build | |||
*.swp | |||
release-tools | |||
vendor | |||
.idea | |||
travis.yml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
travis.yml shouldn't be ignored. no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure, it is ignored in the sidecar, so I added the same ignore here as well.
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except that one comment about travis.yml
e7cc5c2
to
3daa739
Compare
8126cf7
to
3236955
Compare
252d95e
to
895e4c3
Compare
895e4c3
to
f00fe2d
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: krishchow, wlan0 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
This PR adds some utility methods to convert resources between the Spec and the API, these methods can, in turn, be consumed by the sidecar, or vendor drivers. There are also some minor changes to the API to make this process smoother.