Skip to content
This repository was archived by the owner on Dec 3, 2024. It is now read-only.

Update Spec+API versions #39

Merged
merged 2 commits into from
Mar 10, 2021
Merged

Update Spec+API versions #39

merged 2 commits into from
Mar 10, 2021

Conversation

krishchow
Copy link

This PR updates the Spec and API versions in the sidecar and makes all the relevant changes across the project to the code work/compile again.

Note, this is blocked by kubernetes-retired/container-object-storage-interface-api#23

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 5, 2021
@k8s-ci-robot k8s-ci-robot requested review from msau42 and saad-ali March 5, 2021 16:24
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 5, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @krishchow. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Mar 5, 2021
wlan0
wlan0 reviewed Mar 8, 2021
View reviewed changes
pkg/controller/bucketaccess/bucket_access_controller.go
req.Parameters = make(map[string]string)
}

proto, err := bucket.Spec.Protocol.ConvertToExternal()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏾

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: krishchow, wlan0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 8, 2021
@wlan0
Copy link
Contributor

wlan0 commented Mar 8, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 8, 2021
@krishchow
Copy link
Author

/retest

@wlan0
Copy link
Contributor

wlan0 commented Mar 10, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 10, 2021
@k8s-ci-robot k8s-ci-robot merged commit 59ab667 into kubernetes-retired:master Mar 10, 2021
YiannisGkoufas added a commit to YiannisGkoufas/container-object-storage-interface-provisioner-sidecar that referenced this pull request Mar 11, 2021
@YiannisGkoufas
Revert "Merge pull request kubernetes-retired#39 from krishchow/updat…
25e464b 
…e-spec-api"

This reverts commit 59ab667, reversing
changes made to 1f821ec.
@krishchow krishchow mentioned this pull request Mar 15, 2021
Closed
6 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wlan0 wlan0 wlan0 approved these changes

@msau42 msau42 Awaiting requested review from msau42

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees

@wlan0 wlan0

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@krishchow @k8s-ci-robot @wlan0