Skip to content

⚠️ Move FloatingIP to Bastion spec #1739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 14, 2023
Merged

⚠️ Move FloatingIP to Bastion spec #1739

merged 1 commit into from
Nov 14, 2023

Conversation

EmilienM
Copy link
Contributor

@EmilienM EmilienM commented Nov 1, 2023 •
edited
Loading

What this PR does / why we need it:

FloatingIP is not used by the machine controller, only the Bastion. We should move the floating IP configuration to the Bastion spec (OpenStackCluster.Spec.Bastion) instead.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1674

TODOs:

  • squashed commits
  • if necessary:
    • includes documentation
    • Release notes
    • adds unit tests (conversion)

@k8s-ci-robot k8s-ci-robot requested a review from lentzi90 November 1, 2023 18:33
@netlify Netlify
Copy link

netlify bot commented Nov 1, 2023 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
🔨 Latest commit f19a6cc
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/654d3c51e19dc30008847d7e
😎 Deploy Preview https://deploy-preview-1739--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 1, 2023
@EmilienM
Copy link
Contributor Author

EmilienM commented Nov 1, 2023

@mdbooth I'm not sure about this one, whether a conversion can apply; since we're moving the field from one stuct to another.

@jichenjc
Copy link
Contributor

jichenjc commented Nov 2, 2023

/test pull-cluster-api-provider-openstack-test

@jichenjc
Copy link
Contributor

jichenjc commented Nov 2, 2023

please add a release note since API change info will be helpful

lentzi90
lentzi90 reviewed Nov 2, 2023
View reviewed changes
Copy link
Contributor

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the conversion I think we need to look at the OpenStackCluster level in order to convert/move the value.

seanschneeweiss
seanschneeweiss reviewed Nov 2, 2023
View reviewed changes
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 7, 2023
@jichenjc
Copy link
Contributor

jichenjc commented Nov 7, 2023

/test pull-cluster-api-provider-openstack-test

@EmilienM
Copy link
Contributor Author

EmilienM commented Nov 8, 2023

/hold
WIP

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 8, 2023
@EmilienM
Copy link
Contributor Author

EmilienM commented Nov 9, 2023

please add a release note since API change info will be helpful

where are release notes? I thought they were generated. Beside the note in docs/book/src/topics/crd-changes/v1alpha6-to-v1alpha7.md, let me know where I should add content and I'll do it.

Thanks

@jichenjc
Copy link
Contributor

sorry, I mean we should say something like

https://github.com/kubernetes-sigs/cluster-api-provider-openstack/releases said
it's kind of Breaking Changes instead of new features?

@jichenjc
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 10, 2023
@EmilienM EmilienM changed the title ✨ Move FloatingIP to Bastion spec ⚠️ Move FloatingIP to Bastion spec Nov 10, 2023
@EmilienM
Copy link
Contributor Author

@jichenjc thanks, I retitled it to use ⚠️ now.

@jichenjc
Copy link
Contributor

thanks , let's wait for folks to take a look so we can merge it

lentzi90
lentzi90 reviewed Nov 13, 2023
View reviewed changes
Copy link
Contributor

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: EmilienM, lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 13, 2023
@lentzi90
Copy link
Contributor

/test pull-cluster-api-provider-openstack-e2e-full-test

@EmilienM
Copy link
Contributor Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 14, 2023
@k8s-ci-robot k8s-ci-robot merged commit 2858626 into kubernetes-sigs:main Nov 14, 2023
@EmilienM EmilienM deleted the issue_1674 branch November 14, 2023 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanschneeweiss seanschneeweiss seanschneeweiss left review comments

@lentzi90 lentzi90 lentzi90 left review comments

Assignees

@jichenjc jichenjc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove FloatingIP from OpenStackMachineSpec
5 participants
@EmilienM @jichenjc @k8s-ci-robot @lentzi90 @seanschneeweiss