Remove FloatingIP from OpenStackMachineSpec

[mdbooth]

/kind feature

FloatingIP is not used by the machine controller, only the Bastion. We should move the floating IP configuration to the Bastion spec (OpenStackCluster.Spec.Bastion) instead.

[EmilienM]

I agree with Matt, it's only used in the Bastion, see https://github.com/shiftstack/cluster-api-provider-openstack/blob/070714eaa24a25ec6774cbae1c6e140eb8babebe/controllers/openstackcluster_controller.go#L362-L363

[EmilienM]

/reopen

We are reverting. I'll re-add it to main once we have v1alpha8.

[k8s-ci-robot]

@EmilienM: Reopened this issue.

In response to this:

/reopen

We are reverting. I'll re-add it to main once we have v1alpha8.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[EmilienM]

/assign EmilienM

[mdbooth]

@EmilienM We put this back, right?

[EmilienM]

yes, we reverted. I'll get back to it at some point.