Skip to content
This repository was archived by the owner on Oct 28, 2024. It is now read-only.

📖add minikube info into dev doc #192

Merged
merged 1 commit into from
Jul 27, 2021
Merged

📖add minikube info into dev doc #192

merged 1 commit into from
Jul 27, 2021

Conversation

jichenjc
Copy link
Contributor

What this PR does / why we need it:

update doc to include minikube
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 22, 2021
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 22, 2021
neolit123
neolit123 reviewed Jul 22, 2021
View reviewed changes
neolit123
neolit123 reviewed Jul 22, 2021
View reviewed changes
docs/dev-quickstart.md
```
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this removes the empty line at EOF; better to leave it.

neolit123
neolit123 reviewed Jul 22, 2021
View reviewed changes
Copy link

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a couple of comments.

including minikube in the quickstart seems fine; but ideally this document does not want to maintain examples for all the local cluster solutions.

gyliu513
gyliu513 reviewed Jul 23, 2021
View reviewed changes
Copy link
Contributor

@gyliu513 gyliu513 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

kind load docker-image docker.io/virtualcluster/apiserver-v1.16.2:latest --name=capn
kind load docker-image docker.io/virtualcluster/controller-manager-v1.16.2:latest --name=capn
kind load docker-image docker.io/virtualcluster/etcd-v3.4.0:latest --name=capn

This also need minikube mapping.

@gyliu513
Copy link
Contributor

Sorry, last comment, https://github.com/kubernetes-sigs/cluster-api-provider-nested/blob/main/docs/dev-quickstart.md#clean-up also needs updated.

@jichenjc
Copy link
Contributor Author

Sorry, last comment, https://github.com/kubernetes-sigs/cluster-api-provider-nested/blob/main/docs/dev-quickstart.md#clean-up also needs updated.

sure, updated.

@gyliu513
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 26, 2021
christopherhein
christopherhein suggested changes Jul 26, 2021
View reviewed changes
Copy link
Contributor

@christopherhein christopherhein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's hard to apply these comments as suggestions but can we make it so that only the command line commands are contained within the backticks for all of these and break minikube vs kind commands into separate ones?

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 27, 2021
@jichenjc
Copy link
Contributor Author

It's hard to apply these comments as suggestions but can we make it so that only the command line commands are contained within the backticks for all of these and break minikube vs kind commands into separate ones?

updated, thanks~

christopherhein
christopherhein reviewed Jul 27, 2021
View reviewed changes
Copy link
Contributor

@christopherhein christopherhein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

🎉

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 27, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christopherhein, jichenjc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 27, 2021
@k8s-ci-robot k8s-ci-robot merged commit d14245e into kubernetes-retired:main Jul 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@christopherhein christopherhein christopherhein requested changes

@neolit123 neolit123 neolit123 left review comments

@gyliu513 gyliu513 gyliu513 left review comments

@fabriziopandini fabriziopandini Awaiting requested review from fabriziopandini

Assignees

@christopherhein christopherhein

@gyliu513 gyliu513

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jichenjc @gyliu513 @k8s-ci-robot @christopherhein @neolit123