Skip to content
This repository was archived by the owner on Jul 30, 2021. It is now read-only.

🏃 Let GCB build release images #285

Merged

Conversation

ncdc
Copy link
Contributor

@ncdc ncdc commented Dec 17, 2019

What this PR does / why we need it:
test-infra has been updated to use GCB to build release version images,
so we no longer need to do it here in the repo.

Requires kubernetes/test-infra#15624

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

test-infra has been updated to use GCB to build release version
images, so we no longer need to do it here in the repo.

Signed-off-by: Andy Goldstein <[email protected]>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 17, 2019
@ncdc
Copy link
Contributor Author

ncdc commented Dec 17, 2019

/assign @vincepri

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ncdc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 17, 2019
Copy link
Contributor

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ncdc
Copy link
Contributor Author

ncdc commented Dec 17, 2019

Weird, the bot hasn't added the label yet, hmm

@vincepri vincepri added the lgtm Indicates that a PR is ready to be merged. label Dec 17, 2019
@vincepri
Copy link
Contributor

:)

@k8s-ci-robot k8s-ci-robot merged commit 5b53bd0 into kubernetes-retired:master Dec 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants