Skip to content
This repository was archived by the owner on Jul 30, 2021. It is now read-only.

Commit 5b53bd0

Browse files
authored
Merge pull request #285 from ncdc/gcb-for-tag-image-builds
🏃 Let GCB build release images
2 parents af8eedb + a42c13b commit 5b53bd0

File tree

2 files changed

+11
-16
lines changed

2 files changed

+11
-16
lines changed

Makefile

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -183,9 +183,6 @@ $(RELEASE_DIR):
183183
.PHONY: release
184184
release: clean-release ## Builds and push container images using the latest git tag for the commit.
185185
@if [ -z "${RELEASE_TAG}" ]; then echo "RELEASE_TAG is not set"; exit 1; fi
186-
# Push the release image to the staging bucket first.
187-
REGISTRY=$(STAGING_REGISTRY) TAG=$(RELEASE_TAG) \
188-
$(MAKE) docker-build-all docker-push-all
189186
# Set the manifest image to the production bucket.
190187
MANIFEST_IMG=$(PROD_REGISTRY)/$(IMAGE_NAME) MANIFEST_TAG=$(RELEASE_TAG) \
191188
$(MAKE) set-manifest-image

docs/release.md

Lines changed: 11 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,13 @@
11
# How to release this project
22

3-
0. Make sure the manger image patch is pointed to the image tag you will be releasing.
4-
0. If it is not, update it and open a PR. This is the commit you will use to release.
5-
1. `git pull` to get the latest merge commit.
6-
1. Tag the merge commit.
7-
1. Push the tag.
8-
2. GithubActions take over from here.
9-
3. Update the release notes.
10-
4. Send notifications to relevant slack channels and mailing lists.
11-
12-
## Expected artifacts
13-
14-
1. A release with no binaries.
15-
2. A container image pushed to the staging bucket tagged with the released version.
3+
1. Create an annotated tag `git tag -a v0.x.y -m v0.x.y`
4+
1. To use your GPG signature when pushing the tag, use `git tag -s [...]` instead
5+
1. Push the tag to the GitHub repository `git push origin v0.x.y`
6+
1. NB: `origin` should be the name of the remote pointing to
7+
`github.com/kubernetes-sigs/cluster-api-bootstrap-provider-kubeadm`
8+
1. Run `make release` to build artifacts (the image is automatically built by CI)
9+
1. Follow the [Image Promotion process](https://github.com/kubernetes/k8s.io/tree/master/k8s.gcr.io#image-promoter) to
10+
promote the image from the staging repo to `us.gcr.io/k8s-artifacts-prod/capi-kubeadm`
11+
1. Create a release in GitHub based on the tag created above
12+
1. Attach `out/bootstrap-components.yaml` to the release
13+
1. Send notifications to the relevant Slack channels and mailing lists

0 commit comments

Comments
 (0)