Skip to content

update PVC annotations secret supported in external-provisioner #593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

update PVC annotations secret supported in external-provisioner #593

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions book/src/secrets-and-credentials-storage-class.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,9 @@ The values of these parameters may be "templates". The `external-provisioner` wi
* `${pvc.name}`
* Replaced with the name of the `PersistentVolumeClaim` object that triggered provisioning.
* Support added in CSI `external-provisioner` v1.2.0+
* `${pvc.annotations['<ANNOTATION_KEY>']}` (e.g. `${pvc.annotations['example.com/key']}`)
* Replaced with the value of the specified annotation from the `PersistentVolumeClaim` object that triggered provisioning
* Support added in CSI `external-provisioner` v4.0.2+
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think there is a v4.0.2 release, the external-provisioned moved from v4.0.1 to v5.0.0.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the time of creating this PR, it was v4.0.1. Now, it needs to be updated. If someone is interested, they can pick it up

* `csi.storage.k8s.io/provisioner-secret-namespace`
* `${pv.name}`
* Replaced with name of the `PersistentVolume` object being provisioned.
Expand Down