update PVC annotations secret supported in external-provisioner #593
Conversation
Signed-off-by: hoyho <[email protected]>
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
do-not-merge/release-note-label-needed
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: hoyho, jsafrane The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/assign @xing-yang |
|
As v5.0.0 had released https://github.com/kubernetes-csi/external-provisioner/blob/v5.0.0/CHANGELOG/CHANGELOG-5.0.md . I think this PR is ok to merge now. @xing-yang |
|
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
k8s-ci-robot
added
the
lifecycle/stale
|
/remove-lifecycle stale |
k8s-ci-robot
removed
the
lifecycle/stale
|
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
k8s-ci-robot
added
the
lifecycle/stale
|
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
k8s-ci-robot
added
lifecycle/rotten
| @@ -112,6 +112,9 @@ The values of these parameters may be "templates". The `external-provisioner` wi | |||
| * `${pvc.name}` | |||
| * Replaced with the name of the `PersistentVolumeClaim` object that triggered provisioning. | |||
| * Support added in CSI `external-provisioner` v1.2.0+ | |||
| * `${pvc.annotations['<ANNOTATION_KEY>']}` (e.g. `${pvc.annotations['example.com/key']}`) | |||
| * Replaced with the value of the specified annotation from the `PersistentVolumeClaim` object that triggered provisioning | |||
| * Support added in CSI `external-provisioner` v4.0.2+ | |||
There was a problem hiding this comment.
I don't think there is a v4.0.2 release, the external-provisioned moved from v4.0.1 to v5.0.0.
There was a problem hiding this comment.
At the time of creating this PR, it was v4.0.1. Now, it needs to be updated. If someone is interested, they can pick it up
|
@nixpanic: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
As mentioned in kubernetes-csi/external-provisioner#1148, external-provisioner didn't recognize per per volume secret tokens that reference to PVCs. This was fixed is master branch of external-provisioner. CSI document should be updated to advertise this change to users.
However, external-provisioner v4.0.2 hasn't published yet. This PR should wait until the new version is published.