Skip to content

Use oauth2 from google-auth #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 6, 2017

Conversation

strigazi
Copy link
Contributor

@strigazi strigazi commented Jul 4, 2017

oauth2client is deprecated [1], use google-auth.

[1] https://github.com/google/oauth2client/releases (see Note)

Closes: #275

Signed-off-by: Spyros Trigazis [email protected]

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jul 4, 2017
@strigazi
Copy link
Contributor Author

strigazi commented Jul 4, 2017

cla coming

@strigazi
Copy link
Contributor Author

strigazi commented Jul 4, 2017

signed

@strigazi strigazi force-pushed the google-auth branch 4 times, most recently from d2d209d to be87885 Compare July 4, 2017 12:25
@strigazi
Copy link
Contributor Author

strigazi commented Jul 4, 2017

I have signed the cla with my gmail, maybe things are slow.

@strigazi
Copy link
Contributor Author

strigazi commented Jul 4, 2017

@mbohlool Tests are passing locally, I guess I'm doing something wrong with the submodule. It is strange the requirement is in this repo but the it is used in the other repo. Is this a chicken-egg problem?

@mbohlool
Copy link
Contributor

mbohlool commented Jul 5, 2017

Yeah, you need to send a PR to the base repo first.

Here is the base repo: https://github.com/kubernetes-client/python-base/tree/master

If you want to know why we have this submodule you can read this: https://github.com/kubernetes/community/blob/master/contributors/design-proposals/csi-client-structure-proposal.md

@strigazi
Copy link
Contributor Author

strigazi commented Jul 5, 2017

I sent one [1], but how is it going to pass the tests since the requirements are in this repo?

[1] kubernetes-client/python-base#16

@mbohlool
Copy link
Contributor

mbohlool commented Jul 5, 2017

Good point. We don't have a clean way to do it. Have you tried it on a cluster that uses Google Credentials? Our tests does not cover that yet. I can test it manually tomorrow.

@strigazi
Copy link
Contributor Author

strigazi commented Jul 5, 2017

I'll create/delete/list some pods/deployments/svcs

@mbohlool
Copy link
Contributor

mbohlool commented Jul 5, 2017

Thanks, let me know if it worked. We may need to do some tricks to get this in (like add dependency first in this repo without removing old dependency, then merge it and update base repo, then another change in this repo to remove old dependency and update submodule).

@strigazi
Copy link
Contributor Author

strigazi commented Jul 6, 2017

@strigazi strigazi force-pushed the google-auth branch 2 times, most recently from 36ff067 to 5bdf09d Compare July 6, 2017 16:30
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 6, 2017
oauth2client is deprecated [1], use google-auth.

When kubernetes-client/base-python is updated to not use
oauth2client, remove oauth2client.

[1] https://github.com/google/oauth2client/releases (see Note)

Closes: kubernetes-client#275

Signed-off-by: Spyros Trigazis <[email protected]>
@strigazi
Copy link
Contributor Author

strigazi commented Jul 6, 2017

When this is in we can update python-base.

@mbohlool mbohlool merged commit bd4b72e into kubernetes-client:master Jul 6, 2017
strigazi added a commit to strigazi/client-python that referenced this pull request Jul 7, 2017
In kubernetes-client#278 google-auth was added in requirements and in [1]
python-base stopped using it.

Remove oauth2client requirement and update submodule commit.

[1] kubernetes-client/python-base#16

Related-Issue: kubernetes-client#275

Signed-off-by: Spyros Trigazis <[email protected]>
mbohlool pushed a commit that referenced this pull request Jul 7, 2017
In #278 google-auth was added in requirements and in [1]
python-base stopped using it.

Remove oauth2client requirement and update submodule commit.

[1] kubernetes-client/python-base#16

Related-Issue: #275

Signed-off-by: Spyros Trigazis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants