This repository was archived by the owner on Mar 13, 2022. It is now read-only.
Use oauth2 from google-auth #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oauth2client is deprecated [1], use google-auth. [1] https://github.com/google/oauth2client/releases (see Note) Related-Issue: kubernetes-client/python#275 Signed-off-by: Spyros Trigazis <[email protected]>
|
We can take this now. |
Codecov Report
@@ Coverage Diff @@
## master #16 +/- ##
=======================================
Coverage 94.69% 94.69%
=======================================
Files 9 9
Lines 698 698
=======================================
Hits 661 661
Misses 37 37
Continue to review full report at Codecov.
|
|
Failure is not fault of this PR. I send another PR to fix it: #17 |
strigazi
added a commit
to strigazi/client-python
that referenced
this pull request
Jul 7, 2017
In kubernetes-client#278 google-auth was added in requirements and in [1] python-base stopped using it. Remove oauth2client requirement and update submodule commit. [1] kubernetes-client/python-base#16 Related-Issue: kubernetes-client#275 Signed-off-by: Spyros Trigazis <[email protected]>
mbohlool
pushed a commit
to kubernetes-client/python
that referenced
this pull request
Jul 7, 2017
In #278 google-auth was added in requirements and in [1] python-base stopped using it. Remove oauth2client requirement and update submodule commit. [1] kubernetes-client/python-base#16 Related-Issue: #275 Signed-off-by: Spyros Trigazis <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
oauth2client is deprecated [1], use google-auth.
[1] https://github.com/google/oauth2client/releases (see Note)
Related-Issue: kubernetes-client/python#275
Signed-off-by: Spyros Trigazis [email protected]