Skipping TestClient::test_portforward_raw due to flakiness #1481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test is flaking a lot resulting in dev work to be slowed down. This needs to be investigated and resolved. Only then, the test should be reenabled. See: kubernetes-client#1300 Signed-off-by: Nabarun Pal <[email protected]>
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XS
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: palnabarun, yliaog The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
roycaihw
reviewed
Jun 2, 2021
| @@ -214,6 +214,10 @@ def test_exit_code(self): | |||
| resp = api.delete_namespaced_pod(name=name, body={}, | |||
| namespace='default') | |||
|
|
|||
| # Skipping this test as this flakes a lot | |||
| # See: https://github.com/kubernetes-client/python/issues/1300 | |||
| # Re-enable the test once the flakiness is investigated | |||
There was a problem hiding this comment.
nit: prefix this line with a "TODO: "
|
LGTM |
|
I manually restarted the test |
|
I'm going to merge this because the change looks safe. I think travis CI is constantly failing because of a different test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
The test is flaking a lot resulting in dev work being slowed down.
This needs to be investigated and resolved. Only then, the test
should be reenabled.
See: #1300
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
None