Drop python 3.5 #1480
Merged
Drop python 3.5 #1480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
cncf-cla: yes
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: palnabarun, yliaog The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
The test is constantly failing due to #1485 |
Signed-off-by: Nabarun Pal <[email protected]>
Signed-off-by: Nabarun Pal <[email protected]>
Signed-off-by: Nabarun Pal <[email protected]>
Signed-off-by: Nabarun Pal <[email protected]>
palnabarun
force-pushed
the
drop-python-3.5
branch
from
520c314 to
30fe907
Compare
|
New changes are detected. LGTM label has been removed. |
k8s-ci-robot
removed
the
lgtm
|
Ummmm, this is weird. Force pushing to a branch where the PR is lgtm'ed and approved merged the PR. I think this isn't expected. Is it? |
|
(Although the changes proposed in the PR are not very significant) |
|
no, it is not expected, lgtm label was removed, how could it get merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Python 3.5 was EOL'ed on 13 Sep 2020. We shouldn't support Python versions that don't get security updates anymore. (Ref 1, Ref 2)
While going through updating PyYAML due to a CVE fix (#1306), I realized that our dependencies may have dropped support for out-of-support Python minor versions. PyYAML doesn't support Python 3.5 anymore with their latest release.
If we are to fix the CVE, we need to drop Python 3.5. I think we can drop as part of releasing client version v18.y.0b1 as Python doesn't break backward compatibility within minor versions.
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
None