Skip to content

Fix release notes for v18.17.0a1 and v17.14.0a1 in release-18.0 branch #1425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 22, 2021
Merged

Fix release notes for v18.17.0a1 and v17.14.0a1 in release-18.0 branch #1425

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f4a5dd0
fix release notes for v18.17.0a1
roycaihw Apr 22, 2021
f152ecf
Update CHANGELOG with v17.14.0a1
palnabarun Nov 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 12 additions & 17 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,21 +1,6 @@
# v18

**New Feature:**
- Support leader election. [kubernetes-client/python-base#206](https://github.com/kubernetes-client/python-base/pull/206)

**Bug Fix:**
- Raise exception when an empty config file is passed to load_kube_config. [kubernetes-client/python-base#223](https://github.com/kubernetes-client/python-base/pull/223)
- fix: load cache error when CacheDecoder object is not callable. [kubernetes-client/python-base#226](https://github.com/kubernetes-client/python-base/pull/226)
- Fix Watch retries with 410 errors. [kubernetes-client/python-base#227](https://github.com/kubernetes-client/python-base/pull/227)
- Automatically handles chunked or non-chunked responses. Fix ResponseNotChunked error from watch. [kubernetes-client/python-base#231](https://github.com/kubernetes-client/python-base/pull/231)

**API Change:**
- Add allowWatchBookmarks, resoureVersionMatch parameters to custom objects. [kubernetes-client/gen#180](https://github.com/kubernetes-client/gen/pull/180)
# v18.17.0a1


# v18.0.0-snapshot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so there is no snapshot? i noticed 1.17 below still stay at snapshot

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cherry-picked #1322 (just merged into master today) to rename the 1.17 snapshot.

There should be no "snapshot" section in the CHANGELOG.md in a release branch. A "snapshot" section is a placeholder for a WIP release, it can only exists in the master branch, and should be renamed when we cut a release.

The correct order should have been:

  • master branch has 17.0.0-snapshot
  • release-17.0 branch renames 17.0.0-snapshot into v17.14.0a1
  • Cherry-pick: Update CHANGELOG with v17.14.0a1 #1322 cherrypicks the rename back to master branch
  • master branch has 18.0.0-snapshot (this didn't happen, we did everything in release-18.0 and left the master branch behind)
  • release-18.0 branch renames 18.0.0-snapshot into v18.17.0a1 (we are here)
  • cherrypick the rename back to master branch (this is not possible yet. Master branch is still at 17.0.0-snapshot. I need to make the master branch catch up)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok. so the problem is there is only one 'master' branch, which would force the sequential ordering of the releases, that makes parallel releases painful. i think we either fix the above process to make parallel releases easy, or we do just one release a time (once we catch up with the k/k releases).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the sole purpose of this PR is to have the correct release note for v18.17.0a1 in https://github.com/kubernetes-client/python/blob/release-18.0/CHANGELOG.md, which is the linked place we documented in https://github.com/kubernetes-client/python/releases/tag/v18.17.0a1

Copy link
Member Author

@roycaihw roycaihw Apr 22, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we either fix the above process to make parallel releases easy, or we do just one release a time (once we catch up with the k/k releases)

My plan is to do the latter using scripts which automate the release, once we clear up the parallel 17 and 18 releases. Everything starting v18.x.0b1 can be sequential


Kubernetes API Version: 1.18.12
Kubernetes API Version: 1.18.17

**Important Information:**

Expand All @@ -29,7 +14,17 @@ Kubernetes API Version: 1.18.12
- `networkpolicies` resources under `extensions/v1beta1` - use `networking.k8s.io/v1` instead
- `podsecuritypolicies` resources under `extensions/v1beta1` - use `policy/v1beta1` instead ([#85903](https://github.com/kubernetes/kubernetes/pull/85903), [@liggitt](https://github.com/liggitt)) [SIG API Machinery, Apps, Cluster Lifecycle, Instrumentation and Testing]

**New Feature:**
- Support leader election. [kubernetes-client/python-base#206](https://github.com/kubernetes-client/python-base/pull/206)

**Bug Fix:**
- Raise exception when an empty config file is passed to load_kube_config. [kubernetes-client/python-base#223](https://github.com/kubernetes-client/python-base/pull/223)
- fix: load cache error when CacheDecoder object is not callable. [kubernetes-client/python-base#226](https://github.com/kubernetes-client/python-base/pull/226)
- Fix Watch retries with 410 errors. [kubernetes-client/python-base#227](https://github.com/kubernetes-client/python-base/pull/227)
- Automatically handles chunked or non-chunked responses. Fix ResponseNotChunked error from watch. [kubernetes-client/python-base#231](https://github.com/kubernetes-client/python-base/pull/231)

**API Change:**
- Add allowWatchBookmarks, resoureVersionMatch parameters to custom objects. [kubernetes-client/gen#180](https://github.com/kubernetes-client/gen/pull/180)
- Fix bug in reflector that couldn't recover from "Too large resource version" errors ([#92537](https://github.com/kubernetes/kubernetes/pull/92537), [@wojtek-t](https://github.com/wojtek-t)) [SIG API Machinery]
- Fixed: log timestamps now include trailing zeros to maintain a fixed width ([#91207](https://github.com/kubernetes/kubernetes/pull/91207), [@iamchuckss](https://github.com/iamchuckss)) [SIG Apps and Node]
- Fixed: log timestamps now include trailing zeros to maintain a fixed width ([#91207](https://github.com/kubernetes/kubernetes/pull/91207), [@iamchuckss](https://github.com/iamchuckss)) [SIG Apps and Node]
Expand Down