Fix release notes for v18.17.0a1 and v17.14.0a1 in release-18.0 branch #1425
Conversation
k8s-ci-robot
added
kind/documentation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: roycaihw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
|
|
||
|
|
||
| # v18.0.0-snapshot |
There was a problem hiding this comment.
so there is no snapshot? i noticed 1.17 below still stay at snapshot
There was a problem hiding this comment.
Cherry-picked #1322 (just merged into master today) to rename the 1.17 snapshot.
There should be no "snapshot" section in the CHANGELOG.md in a release branch. A "snapshot" section is a placeholder for a WIP release, it can only exists in the master branch, and should be renamed when we cut a release.
The correct order should have been:
- master branch has 17.0.0-snapshot
- release-17.0 branch renames 17.0.0-snapshot into v17.14.0a1
- Cherry-pick: Update CHANGELOG with v17.14.0a1 #1322 cherrypicks the rename back to master branch
- master branch has 18.0.0-snapshot (this didn't happen, we did everything in release-18.0 and left the master branch behind)
- release-18.0 branch renames 18.0.0-snapshot into v18.17.0a1 (we are here)
- cherrypick the rename back to master branch (this is not possible yet. Master branch is still at 17.0.0-snapshot. I need to make the master branch catch up)
There was a problem hiding this comment.
ok. so the problem is there is only one 'master' branch, which would force the sequential ordering of the releases, that makes parallel releases painful. i think we either fix the above process to make parallel releases easy, or we do just one release a time (once we catch up with the k/k releases).
There was a problem hiding this comment.
the sole purpose of this PR is to have the correct release note for v18.17.0a1 in https://github.com/kubernetes-client/python/blob/release-18.0/CHANGELOG.md, which is the linked place we documented in https://github.com/kubernetes-client/python/releases/tag/v18.17.0a1
There was a problem hiding this comment.
i think we either fix the above process to make parallel releases easy, or we do just one release a time (once we catch up with the k/k releases)
My plan is to do the latter using scripts which automate the release, once we clear up the parallel 17 and 18 releases. Everything starting v18.x.0b1 can be sequential
Signed-off-by: Nabarun Pal <[email protected]>
k8s-ci-robot
added
size/M
|
please update the description about renaming 1.17-snapshot |
Done |
roycaihw
changed the title
|
/lgtm |
k8s-ci-robot
added
the
lgtm
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Merge the two section
# v18and# v18.0.0-snapshotinto# v18.17.0a1. Rename "17.0.0-snapshot" into "v17.14.0a1" in sync with the master branch.Does this PR introduce a user-facing change?
/cc @yliaog