-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Document hot issues in release process #1076
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document hot issues in release process #1076
Conversation
@roycaihw: GitHub didn't allow me to request PR reviews from the following users: scottilee. Note that only kubernetes-client members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
da69bff
to
e0794ec
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: roycaihw, yliaog The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
||
2. Add alias package kubernetes.client.apis with deprecation warning. You need | ||
to add [this file](https://github.com/kubernetes-client/python/blob/0976d59d6ff206f2f428cabc7a6b7b1144843b2a/kubernetes/client/apis/__init__.py) | ||
under `kubernetes/client/apis/` to ensure the package is backwards compatible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we ask them to cherry-pick the commit instead or it was multiple commits?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It could be done either by cherry-picking the commit or by copy-pasting the file.
Two hot issues that require manual fixes during release processes. Potentially these fixes can be automated.
/assign @yliaog
/cc @palnabarun @scottilee