Skip to content

Commit 9117d6f

Browse files
authored
Merge pull request #1076 from roycaihw/release-hot-issues
Document hot issues in release process
2 parents 0976d59 + e0794ec commit 9117d6f

File tree

1 file changed

+21
-0
lines changed

1 file changed

+21
-0
lines changed

devel/release.md

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,24 @@ The release process of the python client involves creating (or updating) a relea
44
branch, updating release tags, and creating distribution packages and uploading them to
55
pypi.
66

7+
## Hot issues
8+
9+
There are some hot issues with the client generation that require manual fixes.
10+
***The steps in this section should be performed after you finished the section "Update release tags".***
11+
12+
1. Restore custom object patch hehavior. You should apply [this commit](https://github.com/kubernetes-client/python/pull/995/commits/9959273625b999ae9a8f0679c4def2ee7d699ede)
13+
to ensure custom object patch behavior is backwards compatible. For more
14+
details, see [#866](https://github.com/kubernetes-client/python/issues/866) and
15+
[#959](https://github.com/kubernetes-client/python/pull/959).
16+
17+
2. Add alias package kubernetes.client.apis with deprecation warning. You need
18+
to add [this file](https://github.com/kubernetes-client/python/blob/0976d59d6ff206f2f428cabc7a6b7b1144843b2a/kubernetes/client/apis/__init__.py)
19+
under `kubernetes/client/apis/` to ensure the package is backwards compatible.
20+
For more details, see [#974](https://github.com/kubernetes-client/python/issues/974)
21+
22+
Commit the manual changes like this [PR](https://github.com/kubernetes-client/python/pull/995/commits) does,
23+
then create your PR for review.
24+
725
## Change logs
826
Make sure the change logs are up to date [here](https://github.com/kubernetes-client/python/blob/master/CHANGELOG.md).
927
If they are not, follow commits added after the last release and update/commit
@@ -85,6 +103,9 @@ scripts/update-client.sh
85103
and commit changes (should be only version number changes) to the release branch.
86104
Name the commit something like "Update version constants for XXX release".
87105

106+
***After you finished the steps above, refer to the section "Hot issues" and
107+
apply the manual fixes.***
108+
88109
```bash
89110
git push upstream $RELEASE_BRANCH
90111
```

0 commit comments

Comments
 (0)