Add tox and travis support #9
Conversation
.travis.yml
Outdated
| matrix: | ||
| include: | ||
| - python: 2.7 | ||
| python: 3.4 |
tox.ini
Outdated
| skipsdist = True | ||
| envlist = py | ||
|
|
||
| [testenv] |
There was a problem hiding this comment.
All environment from .travis file will be passed to the main repo tox, coverage is running too (codecov is already commenting on the PR).
mbohlool
force-pushed
the
test
branch
2 times, most recently
from
ca6626a to
e478a85
Compare
Codecov Report
@@ Coverage Diff @@
## master #9 +/- ##
=========================================
Coverage ? 94.69%
=========================================
Files ? 9
Lines ? 698
Branches ? 0
=========================================
Hits ? 661
Misses ? 37
Partials ? 0
Continue to review full report at Codecov.
|
|
@pokoli this is ready now. Thanks for the review. |
api_client.py
Outdated
| # coding: utf-8 | ||
|
|
||
| """ | ||
| Copyright 2016 SmartBear Software |
There was a problem hiding this comment.
Are we sure we can remove this copy right?
There was a problem hiding this comment.
Good catch. I prefer not to remove that. Will fix.
| git config user.email "[email protected]" | ||
| git config user.name "kubenetes client" | ||
| git rm -rf kubernetes/base | ||
| git commit -m "DO NOT MERGE, removing submodule for testing only" |
There was a problem hiding this comment.
I'm wondering why is required to commit, can we avoid it?
There was a problem hiding this comment.
Update-pep8 check will fail if there is an uncommited change.
There was a problem hiding this comment.
Acknowledged. I was not aware of this part! Great.
|
@mbohlool Looks good to me. I added two minor comments, but for me it can be merged. Good work. |
|
LGTM |
fixes #3
based on #6 by @pokoli