Skip to content
This repository was archived by the owner on Mar 13, 2022. It is now read-only.

Add tox and travis support #7

Closed
wants to merge 1 commit into from

Conversation

mbohlool
Copy link
Contributor

@mbohlool mbohlool commented Jun 6, 2017

fixes #3

based on #6 by @pokoli

Copy link

@pokoli pokoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should activate travis on this repository to ensure it's passing correctly before merging

# ref: https://docs.travis-ci.com/user/languages/python
language: python
env:
- TOXENV=py36
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

py36 is not available on default python image. Must be specified as image.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean travis default python image, right? It said it is supported here: https://docs.travis-ci.com/user/languages/python/ I assume they've added it.

function cleanup()
{
cd "${RUNNING_DIR}"
# rm -rf "${TMP_DIR}"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this comment really required?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will remove.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will remove.

@mbohlool
Copy link
Contributor Author

mbohlool commented Jun 7, 2017

I did activate travis but it seems that it does not work unless we merge or maybe recreate PR. I will try recreating PR tomorrow. On my phone now.

@mbohlool
Copy link
Contributor Author

mbohlool commented Jun 8, 2017

Closing this in favor of #9 that is also running the travis check.

@mbohlool mbohlool closed this Jun 8, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tox and travis
2 participants