-
Notifications
You must be signed in to change notification settings - Fork 183
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should activate travis on this repository to ensure it's passing correctly before merging
# ref: https://docs.travis-ci.com/user/languages/python | ||
language: python | ||
env: | ||
- TOXENV=py36 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
py36 is not available on default python image. Must be specified as image.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean travis default python image, right? It said it is supported here: https://docs.travis-ci.com/user/languages/python/ I assume they've added it.
function cleanup() | ||
{ | ||
cd "${RUNNING_DIR}" | ||
# rm -rf "${TMP_DIR}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this comment really required?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will remove.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will remove.
I did activate travis but it seems that it does not work unless we merge or maybe recreate PR. I will try recreating PR tomorrow. On my phone now. |
Closing this in favor of #9 that is also running the travis check. |
fixes #3
based on #6 by @pokoli