Skip to content

Add automatic module names #2681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 30, 2023
Merged

Add automatic module names #2681

merged 2 commits into from
May 30, 2023

Conversation

loffing
Copy link
Contributor

@loffing loffing commented May 25, 2023 •
edited
Loading

Fix #2656 by adding Automatic-Module-Name manifest headers to appropriate jars. Values for the headers are derived from artifact IDs.

These modules can be used as follows:

module my.module {
    requires io.kubernetes.client.java;
    requires io.kubernetes.client.java.api;
    requires io.kubernetes.client.java.extended;
    requires io.kubernetes.client.java.proto;
    requires io.kubernetes.client.java.spring.integration;
    requires io.kubernetes.client.java.spring.aot.integration;
}

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 25, 2023
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 25, 2023
loffing
loffing commented May 25, 2023
View reviewed changes
fluent-gen/pom.xml
@@ -22,7 +22,6 @@
<plugin>
<groupId>org.apache.felix</groupId>
<artifactId>maven-bundle-plugin</artifactId>
<version>5.1.9</version>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version already defined in parent pom

fluent/pom.xml
@@ -35,7 +35,6 @@
<plugin>
<groupId>org.apache.felix</groupId>
<artifactId>maven-bundle-plugin</artifactId>
<version>5.1.9</version>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version already defined in parent pom

proto/pom.xml
@@ -25,6 +25,11 @@
<groupId>org.apache.felix</groupId>
<artifactId>maven-bundle-plugin</artifactId>
<extensions>true</extensions>
<configuration>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The alignment looks wrong here because this file has a mix of tabs and spaces. Let me know if I should format the entire file for consistency.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 26, 2023
@loffing
Copy link
Contributor Author

loffing commented May 26, 2023

/easycla

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 26, 2023
@brendandburns
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 26, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, loffing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 26, 2023
@loffing loffing mentioned this pull request May 27, 2023
Merged
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 27, 2023
@loffing
Copy link
Contributor Author

loffing commented May 27, 2023

Whoops. Looks like I inadvertently removed the LGTM label by syncing my fork.

@brendandburns
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 30, 2023
@brendandburns
Copy link
Contributor

CRD generation is flaking for some reason. Manual merge.

@brendandburns brendandburns merged commit 57a9c55 into kubernetes-client:master May 30, 2023
@loffing loffing deleted the feat-java-modules branch May 30, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendandburns brendandburns Awaiting requested review from brendandburns

@yue9944882 yue9944882 Awaiting requested review from yue9944882

Assignees

@brendandburns brendandburns

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Java Module System
3 participants
@loffing @brendandburns @k8s-ci-robot