Fix Maven build warnings and minor doc issues #2675
Conversation
k8s-ci-robot
added
the
do-not-merge/work-in-progress
k8s-ci-robot
added
the
cncf-cla: no
|
Welcome @loffing! |
k8s-ci-robot
added
size/M
| @@ -1,5 +1,5 @@ | |||
| # This workflow will build a Java project with Maven | |||
| # For more information see: https://help.github.com/actions/language-and-framework-guides/building-and-testing-java-with-maven | |||
| # For more information see: https://docs.github.com/actions/automating-builds-and-tests/building-and-testing-java-with-maven | |||
There was a problem hiding this comment.
Noticed that this URL was broken and just redirects to the support landing page
| @@ -6,9 +6,6 @@ | |||
| <name>client-java-fluent-gen</name> | |||
| <url>https://github.com/kubernetes-client/java</url> | |||
| <description>Client Java Fluent Generator</description> | |||
| <prerequisites> | |||
There was a problem hiding this comment.
Replaced the prerequisites tag with maven-enforcer-plugin to eliminate warnings like the following:
[WARNING] The project io.kubernetes:client-java-parent:pom:18.0.0-SNAPSHOT uses prerequisites which is only intended for maven-plugin projects but not for non maven-plugin projects. For such purposes you should use the maven-enforcer-plugin. See https://maven.apache.org/enforcer/enforcer-rules/requireMavenVersion.html
| @@ -392,6 +388,16 @@ | |||
| <artifactId>gmavenplus-plugin</artifactId> | |||
| <version>2.1.0</version> | |||
| </plugin> | |||
| <plugin> | |||
| <groupId>org.jacoco</groupId> | |||
| <artifactId>jacoco-maven-plugin</artifactId> | |||
There was a problem hiding this comment.
Defined version for jacoco-maven-plugin in parent pom to eliminate warnings like the following:
[WARNING] Some problems were encountered while building the effective model for io.kubernetes:client-java:bundle:18.0.0-SNAPSHOT
[WARNING] 'build.plugins.plugin.version' for org.jacoco:jacoco-maven-plugin is missing. @ line 123, column 21
[WARNING]
[WARNING] Some problems were encountered while building the effective model for io.kubernetes:client-java-spring-integration:bundle:18.0.0-SNAPSHOT
[WARNING] 'build.plugins.plugin.version' for org.jacoco:jacoco-maven-plugin is missing. @ line 77, column 15
[WARNING]
[WARNING] Some problems were encountered while building the effective model for io.kubernetes:client-java-spring-aot-integration:bundle:18.0.0-SNAPSHOT
[WARNING] 'build.plugins.plugin.version' for org.jacoco:jacoco-maven-plugin is missing. @ line 52, column 21
[WARNING]
[WARNING] It is highly recommended to fix these problems because they threaten the stability of your build.
[WARNING]
[WARNING] For this reason, future Maven versions might no longer support building such malformed projects.
I believe this issue was introduced in #2493 when the jacoco-maven-plugin dependency was moved to the parent pom, but not added to the pluginManagement block.
| @@ -568,7 +593,6 @@ limitations under the License. | |||
| <plugin> | |||
| <groupId>org.jacoco</groupId> | |||
| <artifactId>jacoco-maven-plugin</artifactId> | |||
| <version>0.8.10</version> | |||
There was a problem hiding this comment.
Version now defined in parent pom
k8s-ci-robot
added
cncf-cla: no
|
/easycla |
k8s-ci-robot
added
cncf-cla: yes
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, loffing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
@brendandburns Do you know why the Looks like the |
prerequisitestag (replaced bymaven-enforcer-plugin)jacoco-maven-plugin(introduced by Chore: Merge jacoco maven plugin declaration to parent pom #2493)