Optionally disallow "WIP", "Merge" ( and fixup! / squash!) #101
Comments
Narretz
added a commit
to angular/angular.js
that referenced
this issue
Jul 12, 2017
This will provide feedback to contributors without getting in the way of writing invalid commit messages locally. The git hook integration is turned off. Committers who push directly to the repo can be expected to use correct commit messages ;) Most changes go through PRs anyway. Note that "Merge commit" messages and everything starting with "WIP" is always allowed by commitplease. Follow issue jzaefferer/commitplease#101 for more info. Related to #14888 Closes #16097
1 task
|
@Narretz would you be interested in implementing the necessary change in a PR? |
|
Not at the moment - I'd need to familiarize with the code first |
Narretz
added a commit
to Narretz/angular.js
that referenced
this issue
Jul 14, 2017
This will provide feedback to contributors without getting in the way of writing invalid commit messages locally. The git hook integration is turned off. Committers who push directly to the repo can be expected to use correct commit messages ;) Most changes go through PRs anyway. Note that "Merge commit" messages and everything starting with "WIP" is always allowed by commitplease. Follow issue jzaefferer/commitplease#101 for more info. Related to angular#14888 Closes angular#16097
Narretz
added a commit
to Narretz/angular.js
that referenced
this issue
Jul 14, 2017
This will provide feedback to contributors without getting in the way of writing invalid commit messages locally. The git hook integration is turned off. Committers who push directly to the repo can be expected to use correct commit messages ;) Most changes go through PRs anyway. Note that "Merge commit" messages and everything starting with "WIP" is always allowed by commitplease. Follow issue jzaefferer/commitplease#101 for more info. Related to angular#14888 Closes angular#16097
|
A PR with updated tests or docs or both would already help. Otherwise I'm hoping @all3fox can help out |
Narretz
added a commit
to angular/angular.js
that referenced
this issue
Jul 14, 2017
This will provide feedback to contributors without getting in the way of writing invalid commit messages locally. The git hook integration is turned off. Committers who push directly to the repo can be expected to use correct commit messages ;) Most changes go through PRs anyway. Note that "Merge commit" messages and everything starting with "WIP" is always allowed by commitplease. Follow issue jzaefferer/commitplease#101 for more info. Related to #14888 Closes #16097
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
These exceptions are hard-coded in https://github.com/jzaefferer/commitplease/blob/cec0dd6d28ed1ec42843285192072877830c1f96/lib/validate.js as far as I can see.
This is okay when a commit range gets reviewed before merging, but to be 100% strict, you should be able to turn off any of this in specific circumstances / make it overwritable like the config)
For example, in Angular / AngularJS merge commits are actually disallowed - everything must be rebased and the merge commit must be squashed.
We are also adding commitplease to Travis in AngularJS and fixup! and squash! are okay, but WIP isn't
The text was updated successfully, but these errors were encountered: