This repository was archived by the owner on Apr 12, 2024. It is now read-only.
chore(travis): add commitplease validation to ci-checks #16097
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Narretz
force-pushed
the
chore-travis-commitplease
branch
2 times, most recently
from
b9792d7 to
8239dc4
Compare
3 tasks
This will provide feedback to contributors without getting in the way of writing invalid commit messages locally. The git hook integration is turned off. Committers who push directly to the repo can be expected to use correct commit messages ;) Most changes go through PRs anyway. Related to angular#14888
Narretz
force-pushed
the
chore-travis-commitplease
branch
from
8239dc4 to
677962b
Compare
petebacondarwin
previously requested changes
Jul 12, 2017
|
I saw this more as a help for contributors to check their PR commit message validity. PRs must be merged manually anyway and since we can squash via the UI I think it's unnecessary to require a full commit message on each fixup / squash. |
|
I think fixup/squash commits are fine (contributors don't use them that much anyway 😃), but (Given that this is an extra check compared to what we had before, I don't mind it being less strict.) |
petebacondarwin
dismissed
their stale review
OK, I am happy to go with your opinion here.
petebacondarwin
approved these changes
Jul 12, 2017
|
I've opened an issue about WIP / Merge in the commitplease REPO. It's odd that this is hardcoded: jzaefferer/commitplease#101 If you're being strict, Angular style commit message actually disallows Merge commits |
Narretz
added a commit
to Narretz/angular.js
that referenced
this pull request
Jul 14, 2017
This will provide feedback to contributors without getting in the way of writing invalid commit messages locally. The git hook integration is turned off. Committers who push directly to the repo can be expected to use correct commit messages ;) Most changes go through PRs anyway. Note that "Merge commit" messages and everything starting with "WIP" is always allowed by commitplease. Follow issue jzaefferer/commitplease#101 for more info. Related to angular#14888 Closes angular#16097
Narretz
added a commit
to Narretz/angular.js
that referenced
this pull request
Jul 14, 2017
This will provide feedback to contributors without getting in the way of writing invalid commit messages locally. The git hook integration is turned off. Committers who push directly to the repo can be expected to use correct commit messages ;) Most changes go through PRs anyway. Note that "Merge commit" messages and everything starting with "WIP" is always allowed by commitplease. Follow issue jzaefferer/commitplease#101 for more info. Related to angular#14888 Closes angular#16097
Narretz
added a commit
that referenced
this pull request
Jul 14, 2017
This will provide feedback to contributors without getting in the way of writing invalid commit messages locally. The git hook integration is turned off. Committers who push directly to the repo can be expected to use correct commit messages ;) Most changes go through PRs anyway. Note that "Merge commit" messages and everything starting with "WIP" is always allowed by commitplease. Follow issue jzaefferer/commitplease#101 for more info. Related to #14888 Closes #16097
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
chore
What is the current behavior? (You can also link to an open issue here)
PR commit messages are not validated
What is the new behavior (if this is a feature change)?
travis validates PR commit messages
Does this PR introduce a breaking change?
No
Please check if the PR fulfills these requirements
Other information: