Avoid reparsing a Gtid to copy in sub/add #391
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darnuria
changed the title
|
Alternative way: just remove the new method and directly |
darnuria
force-pushed
the
gtid-cpy-ctor
branch
3 times, most recently
from
5bbf554 to
481b9a1
Compare
darnuria
force-pushed
the
gtid-cpy-ctor
branch
from
481b9a1 to
c9b69dc
Compare
darnuria
changed the title
|
Reduced a lot the scope of the PR thanks to discussion with @linkmauve a friend of mine. :) |
|
Would be safer to land after #390, or I just missed test for add/sub. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wanted to avoid some reparsing in
sub,add.