Unit testing for GTID/GtidSet #390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Had some fun doing in rust the whole GTID thing so I wil contribute back the unit testing + doc. :) May have also a better algorithm for adding interval and remove interval but prefers finish testings. |
darnuria
force-pushed
the
unit-test/intervals
branch
2 times, most recently
from
033666b to
4b6eb39
Compare
|
I think this one is ready for review. I may have left a little bit too much of redundancy in test about add/sub but it will not hurt I suppose. Edit: Just force-pushed a test for parsing error. |
darnuria
force-pushed
the
unit-test/intervals
branch
from
4b6eb39 to
462bf2a
Compare
- parsing - intervals - sub/add - encode/decode - ordering
darnuria
force-pushed
the
unit-test/intervals
branch
from
462bf2a to
cdead05
Compare
darnuria
commented
Dec 21, 2022
|
Thanks ! |
|
Thank for the review time! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a bit redundant with test about GtidSet but if it makes sense I can add more.