Skip to content

Make no-find-dom-node work correctly with named imports #1276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 26, 2017
Merged

Make no-find-dom-node work correctly with named imports #1276

merged 1 commit into from
Jun 26, 2017

Conversation

Hypnosphi
Copy link
Contributor

Fixes #785

ljharb
ljharb approved these changes Jun 26, 2017
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be nice if we ensured that findDOMNode originally came from the React or ReactDOM objects, but this is a strict improvement for now.

@ljharb ljharb added the bug label Jun 26, 2017
@ljharb ljharb requested review from yannickcr, lencioni and EvHaus June 26, 2017 16:08
@ljharb ljharb merged commit f70b417 into jsx-eslint:master Jun 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

@lencioni lencioni lencioni approved these changes

@yannickcr yannickcr Awaiting requested review from yannickcr

@EvHaus EvHaus Awaiting requested review from EvHaus

Assignees
No one assigned
Labels
bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Hypnosphi @ljharb @lencioni