Skip to content

Commit f70b417

Browse files
authored
Merge pull request #1276 from Hypnosphi/fix/no-find-dom-node
Make no-find-dom-node work correctly with named imports
2 parents e670022 + cbe8ae9 commit f70b417

File tree

2 files changed

+15
-1
lines changed

2 files changed

+15
-1
lines changed

lib/rules/no-find-dom-node.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ module.exports = {
2929
var callee = node.callee;
3030

3131
var isfindDOMNode =
32-
(callee.object && callee.object.callee && callee.object.callee.name === 'findDOMNode') ||
32+
(callee.name === 'findDOMNode') ||
3333
(callee.property && callee.property.name === 'findDOMNode')
3434
;
3535

tests/lib/rules/no-find-dom-node.js

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -106,5 +106,19 @@ ruleTester.run('no-find-dom-node', rule, {
106106
errors: [{
107107
message: 'Do not use findDOMNode'
108108
}]
109+
}, {
110+
code: [
111+
'class Hello extends Component {',
112+
' componentDidMount() {',
113+
' this.node = findDOMNode(this);',
114+
' }',
115+
' render() {',
116+
' return <div>Hello</div>;',
117+
' }',
118+
'};'
119+
].join('\n'),
120+
errors: [{
121+
message: 'Do not use findDOMNode'
122+
}]
109123
}]
110124
});

0 commit comments

Comments
 (0)