Skip to content

Upgrade aria-query and axobject-query libraries, with changes to remove Map and Set usage #814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 24, 2022
Merged

Upgrade aria-query and axobject-query libraries, with changes to remove Map and Set usage #814

merged 1 commit into from
Oct 24, 2022

Conversation

jessebeach
Copy link
Collaborator

@jessebeach jessebeach commented Oct 2, 2021 •
edited by ljharb
Loading

Closes #875.

This was referenced Oct 2, 2021
Merged
Merged
ljharb
ljharb reviewed Oct 3, 2021
View reviewed changes
@ljharb ljharb marked this pull request as draft October 3, 2021 02:07
@ljharb

This comment has been minimized.

Sign in to view
@codecov
Copy link

codecov bot commented Oct 4, 2021 •
edited
Loading

Codecov Report

Merging #814 (7b3cda3) into main (bccf0ae) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #814   +/-   ##
=======================================
  Coverage   99.29%   99.29%           
=======================================
  Files         103      103           
  Lines        1571     1571           
  Branches      514      514           
=======================================
  Hits         1560     1560           
  Misses         11       11

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jessebeach jessebeach marked this pull request as ready for review October 4, 2021 01:11
@jessebeach jessebeach requested a review from ljharb October 8, 2021 04:21
@jessebeach
Copy link
Collaborator Author

I'm getting back to this this week.

ljharb
ljharb reviewed Jan 31, 2022
View reviewed changes
@jessebeach jessebeach force-pushed the upgrade-query-libraries branch 2 times, most recently from 72e036a to e13b2c4 Compare February 7, 2022 00:39
ljharb
ljharb reviewed Feb 7, 2022
View reviewed changes
@matthieujabbour
Copy link

@jessebeach thanks for your work! Any chance this PR will be merged in the coming weeks?

@jessebeach
Copy link
Collaborator Author

I'll have time in September while I'm on parental leave to get this landed.

This was referenced Aug 22, 2022
Closed
Closed
@puresick puresick mentioned this pull request Aug 23, 2022
Open
@ArnaudBarre ArnaudBarre mentioned this pull request Sep 4, 2022
Closed
@jessebeach jessebeach force-pushed the upgrade-query-libraries branch from e13b2c4 to 5f1547c Compare September 11, 2022 00:12
@jessebeach jessebeach mentioned this pull request Sep 25, 2022
Merged
3 tasks
@jessebeach jessebeach marked this pull request as draft October 21, 2022 06:06
@jessebeach jessebeach force-pushed the upgrade-query-libraries branch from 5f1547c to 043b0e4 Compare October 21, 2022 06:06
ljharb
ljharb reviewed Oct 21, 2022
View reviewed changes
ljharb
ljharb reviewed Oct 21, 2022
View reviewed changes
@jessebeach jessebeach force-pushed the upgrade-query-libraries branch from 043b0e4 to aead11c Compare October 21, 2022 06:38
ljharb
ljharb reviewed Oct 21, 2022
View reviewed changes
@jessebeach jessebeach force-pushed the upgrade-query-libraries branch from aead11c to b53d608 Compare October 23, 2022 03:12
@jessebeach jessebeach force-pushed the upgrade-query-libraries branch from b53d608 to 33b4625 Compare October 23, 2022 03:31
@jessebeach
Copy link
Collaborator Author

Well, it only took a year, but here we go, ready to commit :)

@ljharb for the final review.

@jessebeach jessebeach marked this pull request as ready for review October 23, 2022 03:49
@ljharb ljharb force-pushed the upgrade-query-libraries branch from 33b4625 to 7b3cda3 Compare October 24, 2022 04:53
@ljharb ljharb merged commit 7b3cda3 into main Oct 24, 2022
@ljharb ljharb deleted the upgrade-query-libraries branch October 24, 2022 05:10
@ljharb ljharb mentioned this pull request Oct 26, 2022
Closed
@khiga8 khiga8 mentioned this pull request Dec 2, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@styfle styfle styfle left review comments

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jessebeach @ljharb @matthieujabbour @styfle