Skip to content

Bump aria-query to v5 to reduce install size #889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ArnaudBarre opened this issue Sep 4, 2022 · 1 comment
Closed

Bump aria-query to v5 to reduce install size #889

ArnaudBarre opened this issue Sep 4, 2022 · 1 comment

Comments

@ArnaudBarre
Copy link

ArnaudBarre commented Sep 4, 2022

The version 4 depends on @babel/runtime-corejs3 which depends on core-js-pure, a non negligible 12M dependency.

Changelog: https://github.com/A11yance/aria-query/blob/main/CHANGELOG.md#500

Package Phobia: https://packagephobia.com/[email protected] (which is less than what I effectively get locally)

Edit: Sorry, I didn't check open pull requests. Fix: #814

@ljharb
Copy link
Member

ljharb commented Sep 4, 2022

This is an eslint plugin; its size is utterly irrelevant. Install size is a non-problem - only bundle size matters (and bundle size can’t be measured without the entirety of your application available).

@ljharb ljharb closed this as not planned Won't fix, can't repro, duplicate, stale Sep 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants