Pin axe-core version #666
Merged
Pin axe-core version #666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pin axe-core to v3.4.1 which is the latest version in which tests for the 'autocomplete-valid' rule pass. See jsx-eslint#665 and dequelabs/axe-core#2060 for more information and small discussion.
ljharb
approved these changes
Feb 24, 2020
matijs
force-pushed
the
fix/pin-axe-core-version
branch
from
7f3844f to
43dbd29
Compare
I haven't had time yet. |
|
Let’s do that before merging here, so we don’t forget. |
|
I filed an issue |
ljharb
force-pushed
the
fix/pin-axe-core-version
branch
from
43dbd29 to
f13dc38
Compare
|
thanks for this "beast" of a PR :-p |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pin
axe-coreto v3.4.1 which is the latest version in which tests forthe 'autocomplete-valid' rule pass.
See this PR for more
information and small discussion.