Fix autocomplete-valid-test #665
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`data` was never passed and `.fail` is not a function.
|
Cloning the repo and running Fixing the tests makes them pass locally but then they fail in CI (Does Travis use a cached version of node_modules somehow?). Experimenting with manually downgrading
It looks like this change that ended up in |
|
Always and forever, only apps should have lockfiles. |
|
Observable is public, so this looks like a breaking change in a patch version of axe-core. We can peg the version in package.json to get tests passing again. |
matijs
referenced
this pull request
in matijs/eslint-plugin-jsx-a11y
Feb 24, 2020
Pin axe-core to v3.4.1 which is the latest version in which tests for the 'autocomplete-valid' rule pass. See [this PR](https://github.com/evcohen/eslint-plugin-jsx-a11y/pull/665) for more information and small discussion.
Merged
|
Closed in favour of #666 |
matijs
referenced
this pull request
in matijs/eslint-plugin-jsx-a11y
Feb 24, 2020
Pin axe-core to v3.4.1 which is the latest version in which tests for the 'autocomplete-valid' rule pass. See [this PR](https://github.com/evcohen/eslint-plugin-jsx-a11y/pull/665) for more information and small discussion.
ljharb
pushed a commit
to matijs/eslint-plugin-jsx-a11y
that referenced
this pull request
Feb 26, 2020
Pin axe-core to v3.4.1 which is the latest version in which tests for the 'autocomplete-valid' rule pass. See jsx-eslint#665 and dequelabs/axe-core#2060 for more information and small discussion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
datawas never passed and.failis not a function.@WilcoFiers
._auditlooks like it's axe-core internal and it's the only reasonaxe-coreis used ineslint-plugin-jsx-a11y. Are there plans to make this part of the public axe-core API?