Skip to content

[feature] suggest tabindex 0 or -1 for interactive-supports-focus #952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ckundo opened this issue Sep 5, 2023 · 1 comment · Fixed by #1023
Closed

[feature] suggest tabindex 0 or -1 for interactive-supports-focus #952

ckundo opened this issue Sep 5, 2023 · 1 comment · Fixed by #1023

Comments

@ckundo
Copy link

ckundo commented Sep 5, 2023

When interactive-supports-focus fails, the only reasonable solution is to add a tabindex of either 0 or -1.

Modify interactive-supports-focus to have hasSuggestions: true with a suggest array with 2 entries for fixing to 0 or -1.

Related to #951

lb- added a commit to lb-/eslint-plugin-jsx-a11y that referenced this issue Oct 23, 2024
Add basic support for Eslint rule suggestions for the `interactive-supports-focus` for tabIndex values when elements are interactive but do not have implicit focusable browser behaviour.
These are intentionally not auto-fix but simply optional suggestions to help developers resolve their issue.

Fixes jsx-eslint#952
See also jsx-eslint#951
lb- added a commit to lb-/eslint-plugin-jsx-a11y that referenced this issue Oct 23, 2024
Add basic support for ESlint rule suggestions for the `interactive-supports-focus` for tabIndex values when elements are interactive but do not have implicit focusable browser behaviour.
These are intentionally not auto-fix but simply optional suggestions to help developers resolve their issue.

Fixes jsx-eslint#952
See also jsx-eslint#951
lb- added a commit to lb-/eslint-plugin-jsx-a11y that referenced this issue Oct 23, 2024
Add basic support for ESlint rule suggestions for the `interactive-supports-focus` for tabIndex values when elements are interactive but do not have implicit focusable browser behaviour.
These are intentionally not auto-fix but simply optional suggestions to help developers resolve their issue.

Fixes jsx-eslint#952
See also jsx-eslint#951
lb- added a commit to lb-/eslint-plugin-jsx-a11y that referenced this issue Oct 23, 2024
Add basic support for ESlint rule suggestions for the `interactive-supports-focus` for tabIndex values when elements are interactive but do not have implicit focusable browser behaviour.
These are intentionally not auto-fix but simply optional suggestions to help developers resolve their issue.

Fixes jsx-eslint#952
See also jsx-eslint#951
@lb-
Copy link
Contributor

lb- commented Oct 23, 2024

PR up with an implementation for this #1023

lb- added a commit to lb-/eslint-plugin-jsx-a11y that referenced this issue Oct 25, 2024
Add basic support for ESlint rule suggestions for the `interactive-supports-focus` for tabIndex values when elements are interactive but do not have implicit focusable browser behaviour.
These are intentionally not auto-fix but simply optional suggestions to help developers resolve their issue.

Fixes jsx-eslint#952
See also jsx-eslint#951
@ljharb ljharb closed this as completed in 068608b Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants