unevaluatedProperties: deep dynamic + refs #422
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChALkeR
added a commit
to ExodusMovement/schemasafe
that referenced
this pull request
Jul 27, 2020
ssilverman
approved these changes
Nov 17, 2020
ssilverman
reviewed
Nov 17, 2020
There was a problem hiding this comment.
@ChALkeR can you reformat the JSON so that it matches the style of the rest of the file?
|
@ssilverman The problem is that the formatting in the rest of the file is inconsistent, this is why I never finished this. |
ChALkeR
force-pushed
the
chalker/more-unevaluated
branch
from
d2b64f2 to
8d78c51
Compare
|
Reformatted the newly added section, didn't touch the rest of the file. |
This adds more tests to cover deep dynamic tracing of unevaluated properties inside references. Also a separate test for cyclic refs.
ChALkeR
force-pushed
the
chalker/more-unevaluated
branch
from
8d78c51 to
320457e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds more tests to cover deep dynamic tracing of unevaluated
properties inside references.
Also a separate test for cyclic refs.
This covers multiple paths in impl I wrote that were not covered by the existing tests at all.
I attempted to keep this minimal, it introduces only two schemas.
cc @karenetheridge