Skip to content

Add more nested and cousin unevaluatedProperties tests #411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 14, 2020
Merged

Add more nested and cousin unevaluatedProperties tests #411

merged 1 commit into from
Jul 14, 2020

Conversation

ChALkeR
Copy link
Member

@ChALkeR ChALkeR commented Jul 3, 2020

Subschema application.

I believe some of these combination were not tested by the existing tests.

@ChALkeR ChALkeR marked this pull request as draft July 3, 2020 11:43
@ChALkeR ChALkeR marked this pull request as ready for review July 3, 2020 11:47
karenetheridge
karenetheridge approved these changes Jul 7, 2020
View reviewed changes
Copy link
Member

@karenetheridge karenetheridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested these against my implementation as I added support for unevaluated* and they check out. thanks!

@ChALkeR ChALkeR force-pushed the chalker/more-unevaluted branch from df85692 to cd88fb5 Compare July 14, 2020 15:22
@karenetheridge karenetheridge merged commit dee8ef7 into json-schema-org:master Jul 14, 2020
@karenetheridge
Copy link
Member

thanks again!

@ChALkeR ChALkeR mentioned this pull request Sep 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karenetheridge karenetheridge karenetheridge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChALkeR @karenetheridge