Skip to content

[359] Add unevaluatedProperties/unevaluatedItems cousin tests #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2020

Conversation

ssilverman
Copy link
Member

@ssilverman ssilverman commented May 25, 2020

These tests address the case where they're not direct siblings to their
associated properties.

Closes #359

@ssilverman ssilverman requested review from gregsdennis and a team May 25, 2020 06:12
@ssilverman ssilverman force-pushed the sibling-unevaled branch 2 times, most recently from abd8d1f to f6171b5 Compare May 25, 2020 06:17
These tests address the case where they're not direct siblings to their
associated properties.
@ssilverman ssilverman changed the title [359] Add unevaluatedProperties/unevaluatedItems non-sibling tests [359] Add unevaluatedProperties/unevaluatedItems cousin tests May 25, 2020
@ssilverman ssilverman requested a review from gregsdennis May 25, 2020 16:37
@karenetheridge
Copy link
Member

I believe there already is a patch in the queue that addresses this same usecase (it in fact was the PR that gave rise to the siblings-vs-ancestors question in the first place).

@ssilverman
Copy link
Member Author

Do you have a link to the other PR?

@karenetheridge
Copy link
Member

karenetheridge commented May 27, 2020

I believe it was #317 and #332

@ssilverman
Copy link
Member Author

It doesn't look like #317 or #332 add the "cousin" test cases.

@ssilverman ssilverman merged commit 536ec07 into json-schema-org:master May 27, 2020
@ssilverman ssilverman deleted the sibling-unevaled branch May 27, 2020 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Another unevaluatedProperties test case
3 participants